Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

2021-09-13 Thread Tudor Cornea
Thanks for the observation. I have removed the compile-time kernel version check in v2 of the patch On Mon, 13 Sept 2021 at 18:09, Stephen Hemminger wrote: > On Mon, 13 Sep 2021 17:09:11 +0300 > Tudor Cornea wrote: > > > +static inline bool tx_ring_status_unavailable(uint32_t tp_status) > > +

Re: [dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

2021-09-13 Thread Stephen Hemminger
On Mon, 13 Sep 2021 17:09:11 +0300 Tudor Cornea wrote: > +static inline bool tx_ring_status_unavailable(uint32_t tp_status) > +{ > +#if KERNEL_VERSION(5, 10, 0) > LINUX_VERSION_CODE No, having kernel dependent userspace in DPDK is not good practice. Distribution vendors don't number their kerne

[dpdk-dev] [PATCH] net/af_packet: remove timestamp from packet status

2021-09-13 Thread Tudor Cornea
We should eliminate the timestamp status from the packet status. This should only matter if timestamping is enabled on the socket, but we might hit a kernel bug, which is fixed in newer releases. For interfaces of type 'veth', the sent skb is forwarded to the peer and back into the network stack w