Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings

2021-10-12 Thread Ajit Khaparde
On Mon, Oct 11, 2021 at 7:46 PM Stephen Hemminger wrote: > > On Sat, 9 Oct 2021 21:07:55 -0700 > Ajit Khaparde wrote: > > > + if ((uint32_t)item->type >= > > + (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) { > > > This doesn't look right, you are casting away your troubles,

Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings

2021-10-11 Thread Stephen Hemminger
On Sat, 9 Oct 2021 21:07:55 -0700 Ajit Khaparde wrote: > + if ((uint32_t)item->type >= > + (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) { This doesn't look right, you are casting away your troubles, not addressing the root cause. item->type is type rte_flow_item_type BNX

Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings

2021-10-11 Thread Ajit Khaparde
On Sat, Oct 9, 2021 at 9:07 PM Ajit Khaparde wrote: > > From: Shahaji Bhosle > > Fix an error reported during CLANG compilation. > > -Wtautological-constant-out-of-range-compare for enums > > $ export CC=clang > $ meson --werror --buildtype=debugoptimized build && ninja-build -C build > " > [..]

[dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings

2021-10-10 Thread Ajit Khaparde
From: Shahaji Bhosle Fix an error reported during CLANG compilation. -Wtautological-constant-out-of-range-compare for enums $ export CC=clang $ meson --werror --buildtype=debugoptimized build && ninja-build -C build " [..] ../../root/dpdk/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c:140:18: error: