Re: [dpdk-dev] [PATCH] net/bnxt: fix missing barriers in completion handling

2021-07-09 Thread Lance Richardson
On Fri, Jul 9, 2021 at 2:00 AM Ruifeng Wang wrote: > > > +/** > > + * Check validity of a completion ring entry. If the entry is valid, > > include a > > + * C11 __ATOMIC_ACQUIRE fence to ensure that subsequent loads of fields > > in the > > + * completion are not hoisted by the compiler or by t

Re: [dpdk-dev] [PATCH] net/bnxt: fix missing barriers in completion handling

2021-07-08 Thread Ruifeng Wang
> -Original Message- > From: Lance Richardson > Sent: Friday, July 9, 2021 3:15 AM > To: Ajit Khaparde (ajit.khapa...@broadcom.com) > ; Somnath Kotur > ; Bruce Richardson > ; Konstantin Ananyev > ; jer...@marvell.com; Ruifeng Wang > ; Stephen Hurd ; > David Christensen > Cc: dev@dpdk.org;

[dpdk-dev] [PATCH] net/bnxt: fix missing barriers in completion handling

2021-07-08 Thread Lance Richardson
Ensure that Rx/Tx/Async completion entry fields are accessed only after the completion's valid flag has been loaded and verified. This is needed for correct operation on systems that use relaxed memory consistency models. Fixes: 2eb53b134aae ("net/bnxt: add initial Rx code") Fixes: 6eb3cc2294fd ("