[dpdk-dev] [PATCH] net/bnxt: remove useless prefetches

2020-11-04 Thread Stephen Hemminger
Prefetching only helps performance if it is done several 100 instructions before the actual use. The purpose of the prefetch is to read ahead, it doesn't help if the next instruction will block. The code in the bnxt driver was doing these unnecessary prefetches. Signed-off-by: Stephen Hemminger

Re: [dpdk-dev] [PATCH] net/bnxt: remove useless prefetches

2020-11-05 Thread Lance Richardson
On Wed, Nov 4, 2020 at 12:03 PM Stephen Hemminger wrote: > > Prefetching only helps performance if it is done several 100 > instructions before the actual use. The purpose of the prefetch > is to read ahead, it doesn't help if the next instruction > will block. > > The code in the bnxt driver was

Re: [dpdk-dev] [PATCH] net/bnxt: remove useless prefetches

2020-11-05 Thread Ajit Khaparde
On Thu, Nov 5, 2020 at 7:18 AM Lance Richardson < lance.richard...@broadcom.com> wrote: > On Wed, Nov 4, 2020 at 12:03 PM Stephen Hemminger > wrote: > > > > Prefetching only helps performance if it is done several 100 > > instructions before the actual use. The purpose of the prefetch > > is to r