Re: [dpdk-dev] [PATCH] net/e1000: fix link status update

2019-11-25 Thread Lu, Wenzhuo
Hi, > -Original Message- > From: Cui, LunyuanX > Sent: Thursday, November 14, 2019 1:33 AM > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Yang, Qiming > ; Cui, LunyuanX ; > sta...@dpdk.org > Subject: [PATCH] net/e1000: fix link status update > > Unassigned variable should not be used as judgment,

Re: [dpdk-dev] [PATCH] net/e1000: fix link status update

2019-11-13 Thread Ye Xiaolong
Hi, On 11/13, Cui LunyuanX wrote: >Unassigned variable should not be used as judgment, and there The issue here is link structure variable has been memset first, which makes it meaningless to compare the value of link.link_status in the conditions. >is no need to update link status according to

[dpdk-dev] [PATCH] net/e1000: fix link status update

2019-11-13 Thread Cui LunyuanX
Unassigned variable should not be used as judgment, and there is no need to update link status according to old link status. This patch fix the issue. Fixes: 80ba61115e77 ("net/e1000: use link status helper functions") Cc: sta...@dpdk.org Signed-off-by: Lunyuan Cui --- drivers/net/e1000/em_ethd