Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-16 Thread Sexton, Rory
Hi Beilei, See below, Rory > > > > +/* A structure used to define the input for L2TPv3 flow */ struct > > > > +i40e_l2tpv3_flow { > > > > > > Seems missed struct rte_eth_ipv4_flow or struct rte_eth_ipv6_flow here? > > > > > > > I'm not convinced we need struct rte_eth_ipv4_flow or struct > >

Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-13 Thread Xing, Beilei
> -Original Message- > From: Sexton, Rory > Sent: Friday, December 13, 2019 3:18 AM > To: Xing, Beilei ; dev@dpdk.org > Cc: Zhang, Qi Z ; adrien.mazarg...@6wind.com; > Jagus, DariuszX > Subject: RE: [PATCH] net/i40e: Add new customized pctype for l2tpv3 > > Hi Beilei, > > See comments b

Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-13 Thread Sexton, Rory
Hi Beilei, See comments below. Regards, Rory > > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3 > It's not only add new customized pctype, but mainly enable FDIR for l2ipv3, > so how about " net/i40e: support FDIR for L2TPv3"? > > Detailed commit log is also needed. Of course

Re: [dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-11 Thread Xing, Beilei
> -Original Message- > From: Sexton, Rory > Sent: Wednesday, December 4, 2019 6:11 AM > To: dev@dpdk.org > Cc: Zhang, Qi Z ; Xing, Beilei ; > Sexton, Rory ; adrien.mazarg...@6wind.com; Jagus, > DariuszX > Subject: [PATCH] net/i40e: Add new customized pctype for l2tpv3 It's not only add

[dpdk-dev] [PATCH] net/i40e: Add new customized pctype for l2tpv3

2019-12-04 Thread Rory Sexton
Signed-off-by: Rory Sexton Signed-off-by: Dariusz Jagus --- drivers/net/i40e/i40e_ethdev.c | 11 ++- drivers/net/i40e/i40e_ethdev.h | 9 ++ drivers/net/i40e/i40e_fdir.c | 34 + drivers/net/i40e/i40e_flow.c | 55 ++ 4 files changed,