Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-06 Thread Roger B. Melton
On 10/6/17 9:51 AM, Bruce Richardson wrote: On Fri, Oct 06, 2017 at 08:38:01AM -0400, Roger B. Melton wrote: On 10/6/17 4:54 AM, Bruce Richardson wrote: On Thu, Oct 05, 2017 at 03:11:11PM -0400, Roger B Melton wrote: --- i40evf tx vector logic frees mbufs, but it does not remove the mbufs fro

Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-06 Thread Bruce Richardson
On Fri, Oct 06, 2017 at 08:38:01AM -0400, Roger B. Melton wrote: > On 10/6/17 4:54 AM, Bruce Richardson wrote: > > On Thu, Oct 05, 2017 at 03:11:11PM -0400, Roger B Melton wrote: > > > --- > > > > > > i40evf tx vector logic frees mbufs, but it does not remove the > > > mbufs from software rings wh

Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-06 Thread Roger B. Melton
On 10/6/17 4:54 AM, Bruce Richardson wrote: On Thu, Oct 05, 2017 at 03:11:11PM -0400, Roger B Melton wrote: --- i40evf tx vector logic frees mbufs, but it does not remove the mbufs from software rings which leads to double frees. This change corrects that oversight. We've validated this fix

Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-06 Thread Bruce Richardson
On Thu, Oct 05, 2017 at 03:11:11PM -0400, Roger B Melton wrote: > --- > > i40evf tx vector logic frees mbufs, but it does not remove the > mbufs from software rings which leads to double frees. This change > corrects that oversight. We've validated this fix within our application. > Hi Roger,

Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-05 Thread Ferruh Yigit
On 10/6/2017 12:42 AM, Roger B. Melton wrote: > Hi Everyone, > > As soon as I submitted the patch, I realized I neglected to signoff.  > What's the recommended procedure, resubmit the original signed off, or > bump to v1? Please send a new one increasing version, since this was v1 already next

Re: [dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-05 Thread Roger B. Melton
Hi Everyone, As soon as I submitted the patch, I realized I neglected to signoff.  What's the recommended procedure, resubmit the original signed off, or bump to v1? Thanks, Roger On 10/5/17 3:11 PM, Roger B Melton wrote: --- i40evf tx vector logic frees mbufs, but it does not remove the

[dpdk-dev] [PATCH] net/i40e: Improve i40evf buffer cleanup in tx vector mode

2017-10-05 Thread Roger B Melton
--- i40evf tx vector logic frees mbufs, but it does not remove the mbufs from software rings which leads to double frees. This change corrects that oversight. We've validated this fix within our application. drivers/net/i40e/i40e_rxtx_vec_common.h | 4 1 file changed, 4 insertions(+) di