Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-11 Thread Igor Ryzhov
wind.com>; dev@dpdk.org; Wu, Jingjing ; > sta...@dpdk.org; Laurent Hardy > > *Subject:* Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary > address change > > > > Hello everyone. > > > > It's sad that my comments were unanswered. > > I&

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-11 Thread Xing, Beilei
: Zhang, Helin Cc: Xing, Beilei ; Olivier Matz ; dev@dpdk.org; Wu, Jingjing ; sta...@dpdk.org; Laurent Hardy Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change Hello everyone. It's sad that my comments were unanswered. I'm ok with the first two – they w

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-10 Thread Igor Ryzhov
e- > > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > > Sent: Thursday, January 4, 2018 1:39 PM > > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing > > Cc: sta...@dpdk.org; Laurent Hardy > > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC fil

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-10 Thread Zhang, Helin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Xing, Beilei > Sent: Thursday, January 4, 2018 1:39 PM > To: Olivier Matz; dev@dpdk.org; Wu, Jingjing > Cc: sta...@dpdk.org; Laurent Hardy > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-07 Thread Zhang, Helin
Jingjing; Xing, Beilei; sta...@dpdk.org; Laurent Hardy > Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary > address > change > > Thank you for the patch! Comments inline. > > On Wed, Jan 3, 2018 at 5:29 PM, Olivier Matz > wrote: >

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-05 Thread Igor Ryzhov
Thank you for the patch! Comments inline. On Wed, Jan 3, 2018 at 5:29 PM, Olivier Matz wrote: > > drivers/net/i40e/i40e_ethdev.c | 29 + > 1 file changed, 29 insertions(+) > > diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ > ethdev.c > index 811c

Re: [dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-03 Thread Xing, Beilei
> -Original Message- > From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Wednesday, January 3, 2018 10:29 PM > To: dev@dpdk.org; Wu, Jingjing ; Xing, Beilei > > Cc: sta...@dpdk.org; Laurent Hardy > Subject: [PATCH] net/i40e: fix VSI MAC filter on primary address change > > Whe

[dpdk-dev] [PATCH] net/i40e: fix VSI MAC filter on primary address change

2018-01-03 Thread Olivier Matz
When primary address mac is changed, the mac filters were not updated in the VSI with the new mac addr and incoming packets with this destination address are dropped by the hardware filters. This patch removes the VSI mac filter for the previous mac address and adds a new one for new mac address.