Re: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2021-05-09 Thread Zhang, Qi Z
> -Original Message- > From: Yang, Qiming > Sent: Monday, May 10, 2021 1:02 PM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: RE: [PATCH] net/ice/base: remove unnecessary code > > > > -Original Message- > > From: Zhang, Qi Z > > Sent: Monday, May 10, 2021 11:23 > > To: Yang

Re: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2021-05-09 Thread Yang, Qiming
> -Original Message- > From: Zhang, Qi Z > Sent: Monday, May 10, 2021 11:23 > To: Yang, Qiming > Cc: dev@dpdk.org; Zhang, Qi Z > Subject: [PATCH] net/ice/base: remove unnecessary code > > Coverty issue: 370613 > Execution cannot reach this statement: "break;". > Remove the unnecessary

[dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2021-05-09 Thread Qi Zhang
Coverty issue: 370613 Execution cannot reach this statement: "break;". Remove the unnecessary if branch. Fixes: 2913bc4155d2 ("net/ice/base: sign external device package programming") Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 --- 1 file changed, 3 deletions(-) diff --g

[dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2021-05-09 Thread Qi Zhang
Convery issue: 370613 Execution cannot reach this statement: "break;". Remove the unnecessary if branch. Fixes: 2913bc4155d2 ("net/ice/base: sign external device package programming") Signed-off-by: Qi Zhang --- drivers/net/ice/base/ice_common.c | 3 --- 1 file changed, 3 deletions(-) diff --g

Re: [dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2020-04-08 Thread Ye Xiaolong
On 04/07, Qi Zhang wrote: >Update a switch rule' action from "to VSI" to "to VSI List" >should only happen when the same rule has been programmed with >a different fwd destination. This is already handled by below >code block: > >m_entry = ice_find_adv_rule_entry(...) >if (m_entry) { > ... >

[dpdk-dev] [PATCH] net/ice/base: remove unnecessary code

2020-04-06 Thread Qi Zhang
Update a switch rule' action from "to VSI" to "to VSI List" should only happen when the same rule has been programmed with a different fwd destination. This is already handled by below code block: m_entry = ice_find_adv_rule_entry(...) if (m_entry) { ... ice_adv_add_update_vsi_list