Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-04-01 Thread Zhang, Qi Z
> -Original Message- > From: Ma, WenwuX > Sent: Thursday, April 1, 2021 11:21 PM > To: Yang, Qiming ; Zhang, Qi Z > > Cc: dev@dpdk.org > Subject: [PATCH] net/ice: fix illegal pointer access in dev init > > mac_addrs in dev data should be allocated more memory space, Otherwise, > trave

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-03-31 Thread Wenwu Ma
mac_addrs in dev data should be allocated more memory space, Otherwise, traversing mac_addrs in function eth_dev_mac_restore() will result heap-buffer-overflow. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver

Re: [dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-03-31 Thread Stephen Hemminger
On Thu, 1 Apr 2021 13:24:53 + Wenwu Ma wrote: > + dev->data->mac_addrs = rte_zmalloc(NULL, > + sizeof(struct rte_ether_addr) * ICE_NUM_MACADDR_MAX, 0); This looks like a good place to use rte_calloc().

[dpdk-dev] [PATCH] net/ice: fix illegal pointer access in dev init

2021-03-31 Thread Wenwu Ma
mac_addrs in dev data should be allocated more memory space, Otherwise, traversing mac_addrs in function eth_dev_mac_restore() will result heap-buffer-overflow. Signed-off-by: Wenwu Ma --- drivers/net/ice/ice_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/driver