Re: [dpdk-dev] [PATCH] net/ice: remove unnecessary variable

2020-03-02 Thread Zhang, Qi Z
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, March 2, 2020 4:20 PM > To: Zhang, Qi Z > Cc: Xing, Beilei ; Cao, Yahui ; > dev@dpdk.org; sta...@dpdk.org > Subject: Re: [dpdk-dev] [PATCH] net/ice: remove unnecessary variable > > Hi, Qi &g

Re: [dpdk-dev] [PATCH] net/ice: remove unnecessary variable

2020-03-02 Thread Ye Xiaolong
Hi, Qi On 02/25, Qi Zhang wrote: >Remove unnecessary variable "meta" in ice_flow_create and >ice_flow_validate, it should be defined when really be needed: >its ice_parse_engine_create and ice_parse_engine_validate. > >The patch also move the meta's memory free from each filter s/move/moves >eng

[dpdk-dev] [PATCH] net/ice: remove unnecessary variable

2020-02-25 Thread Qi Zhang
Remove unnecessary variable "meta" in ice_flow_create and ice_flow_validate, it should be defined when really be needed: its ice_parse_engine_create and ice_parse_engine_validate. The patch also move the meta's memory free from each filter engine->create to upper layer, the memory leakage when cre