Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length

2019-10-22 Thread Stephen Hemminger
On Tue, 22 Oct 2019 16:50:40 + "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)" wrote: > > Why does this not use abstract unix domain socket naming? > > That would be much less error prone, because then the socket would > > disappear when all applications using it are closed.

Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length

2019-10-22 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> Why does this not use abstract unix domain socket naming? > That would be much less error prone, because then the socket would > disappear when all applications using it are closed. How would that work with containers? I'll consider that for a new patch, maybe it could be optional?

Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length

2019-10-22 Thread Ferruh Yigit
On 10/22/2019 5:08 PM, Jakub Grajciar wrote: > Define MEMIF_SOCKET_UN_SIZE to size of unix domain socket address. > Report error in case of longer path. > > Fixes: b923866c6974 ("net/memif: allow for full key size in socket name") > Cc: step...@networkplumber.org > > Signed-off-by: Jakub Grajciar

Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length

2019-10-22 Thread Stephen Hemminger
On Tue, 22 Oct 2019 18:08:29 +0200 Jakub Grajciar wrote: > Cc: step...@networkplumber.org > > Signed-off-by: Jakub Grajciar > --- > doc/guides/nics/memif.rst | 2 +- > drivers/net/memif/memif_socket.c | 27 +++ > drivers/net/memif/memif_socket.h | 6 -- >

Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length

2019-10-22 Thread Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
> -Original Message- > From: Ferruh Yigit > Sent: Tuesday, October 22, 2019 6:33 PM > To: Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco) > ; dev@dpdk.org > Cc: step...@networkplumber.org > Subject: Re: [dpdk-dev] [PATCH] net/memif: fix invalid unix do

[dpdk-dev] [PATCH] net/memif: fix invalid unix domain address length

2019-10-22 Thread Jakub Grajciar
Define MEMIF_SOCKET_UN_SIZE to size of unix domain socket address. Report error in case of longer path. Fixes: b923866c6974 ("net/memif: allow for full key size in socket name") Cc: step...@networkplumber.org Signed-off-by: Jakub Grajciar --- doc/guides/nics/memif.rst | 2 +- drivers/n