Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-04-04 Thread Nélio Laranjeiro
On Mon, Apr 02, 2018 at 12:41:33PM +, Xueming(Steven) Li wrote: > > this device should to the same instead of refusing it > > Just double confirm, is it "do the same"? are you suggesting not denying > unsupported hash function in rte_eth_dev_configure()? I mean, if others PMD are ignoring non

Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-04-02 Thread Xueming(Steven) Li
> this device should to the same instead of refusing it Just double confirm, is it "do the same"? are you suggesting not denying unsupported hash function in rte_eth_dev_configure()? From quick view of ixgbe code, kind of try best, would like to hear from other PMDs on how this interpreted. >

Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-03-26 Thread Nélio Laranjeiro
On Thu, Mar 22, 2018 at 10:42:44AM +, Xueming(Steven) Li wrote: > Just remind, denying unsupported hash function in rte_eth_dev_configure() > might > impact some user app using PMD that simply ignoring them silently. If the default behavior from other devices is to use only possible values, t

Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-03-22 Thread Xueming(Steven) Li
Just remind, denying unsupported hash function in rte_eth_dev_configure() might impact some user app using PMD that simply ignoring them silently. Testpmd command "port config rss all" should be updated as well to 'all' supported values from rte_eth_dev_info, I'll include this change in next ve

Re: [dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-03-19 Thread Nélio Laranjeiro
On Sun, Mar 18, 2018 at 03:37:20PM +0800, Xueming Li wrote: > Add supported RSS hash function check in device configuration to > have better error verbosity for application developers. > > Signed-off-by: Xueming Li > --- > drivers/net/mlx5/mlx5_ethdev.c | 8 > 1 file changed, 8 insertion

[dpdk-dev] [PATCH] net/mlx5: add supported hash function check

2018-03-18 Thread Xueming Li
Add supported RSS hash function check in device configuration to have better error verbosity for application developers. Signed-off-by: Xueming Li --- drivers/net/mlx5/mlx5_ethdev.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/net/mlx5/mlx5_ethdev.c b/drivers/net/mlx5/mlx5