Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs getting item and action flags

2018-10-31 Thread Yongseok Koh
> On Oct 31, 2018, at 1:25 AM, Ori Kam wrote: > > Hi, > PSB > >> -Original Message- >> From: Yongseok Koh >> Sent: Monday, October 29, 2018 8:04 PM >> To: Ori Kam >> Cc: Shahaf Shuler ; dev@dpdk.org >> Subject: Re: [PATCH] net/mlx5: fix Direct Verbs getting item and action flags >> >

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs getting item and action flags

2018-10-31 Thread Ori Kam
Hi, PSB > -Original Message- > From: Yongseok Koh > Sent: Monday, October 29, 2018 8:04 PM > To: Ori Kam > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH] net/mlx5: fix Direct Verbs getting item and action flags > > > On Oct 28, 2018, at 11:03 PM, Ori Kam wrote: > > > > Why shou

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs getting item and action flags

2018-10-29 Thread Yongseok Koh
> On Oct 28, 2018, at 11:03 PM, Ori Kam wrote: > > Why should DV prepare function return the list of actions? > > The only reason I can think of, is if you want to remove the for loop in > dv_translate. And then in flow_dv_create_action change the switch case > to ifs. Then, I should ask you a

Re: [dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs getting item and action flags

2018-10-28 Thread Ori Kam
Why should DV prepare function return the list of actions? The only reason I can think of, is if you want to remove the for loop in dv_translate. And then in flow_dv_create_action change the switch case to ifs. Ori > -Original Message- > From: Yongseok Koh > Sent: Sunday, October 28, 2

[dpdk-dev] [PATCH] net/mlx5: fix Direct Verbs getting item and action flags

2018-10-28 Thread Yongseok Koh
Flow driver has to provide detected item flags and action flags via flow_drv_prepare(). DV doesn't return flags at all. Fixes: 865a0c15672c ("net/mlx5: add Direct Verbs prepare function") Cc: or...@mellanox.com Signed-off-by: Yongseok Koh --- drivers/net/mlx5/mlx5_flow_dv.c | 115 ++