Re: [dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check

2020-09-10 Thread Ferruh Yigit
On 9/8/2020 4:47 PM, Stephen Hemminger wrote: > On Tue, 8 Sep 2020 11:06:42 +0100 > Ferruh Yigit wrote: > >> '__builtin_add_overflow' added to gcc in version 5, earlier versions >> causing build error, like gcc 4.8.5 in RHEL7. > > Sigh. Ok, but the security folks really like __builtin_add_overf

Re: [dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check

2020-09-09 Thread Ajit Khaparde
On Tue, Sep 8, 2020 at 3:07 AM Ferruh Yigit wrote: > '__builtin_add_overflow' added to gcc in version 5, earlier versions > causing build error, like gcc 4.8.5 in RHEL7. > > Replaced compiler builtin check with arithmetic check. > > Fixes: cabb3c0f29f1 ("net/netvsc: check for overflow on packet i

Re: [dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check

2020-09-08 Thread Stephen Hemminger
On Tue, 8 Sep 2020 11:06:42 +0100 Ferruh Yigit wrote: > '__builtin_add_overflow' added to gcc in version 5, earlier versions > causing build error, like gcc 4.8.5 in RHEL7. Sigh. Ok, but the security folks really like __builtin_add_overflow.

Re: [dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check

2020-09-08 Thread Raslan Darawsheh
Hi, > -Original Message- > From: Ferruh Yigit > Sent: Tuesday, September 8, 2020 1:07 PM > To: dev@dpdk.org; Stephen Hemminger ; NBU- > Contact-kys ; NBU-Contact-haiyangz > ; NBU-Contact-longli > Cc: Ferruh Yigit ; Raslan Darawsheh > > Subject: [PATCH] net/netvsc: replace compiler built

[dpdk-dev] [PATCH] net/netvsc: replace compiler builtin overflow check

2020-09-08 Thread Ferruh Yigit
'__builtin_add_overflow' added to gcc in version 5, earlier versions causing build error, like gcc 4.8.5 in RHEL7. Replaced compiler builtin check with arithmetic check. Fixes: cabb3c0f29f1 ("net/netvsc: check for overflow on packet info from host") Reported-by: Raslan Darawsheh Signed-off-by: