Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-24 Thread Ferruh Yigit
On 4/23/2018 12:32 PM, Ophir Munk wrote: > Hi Ferruh, > The exact same setup works without your patch (done before sending my first > email). > I started debugging your patch and noticed you have dropped the setting of > txq->csum which always remains 0 therefore [1] is never executed. I see it

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-23 Thread Ophir Munk
hay Haimovsky > Cc: 'dev@dpdk.org' ; Shahaf Shuler > ; Olga Shern ; Raslan > Darawsheh > Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload > support > > On 4/23/2018 10:17 AM, Ophir Munk wrote: > > Hi Ferruh, > > A quick feedback to your

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-23 Thread Ferruh Yigit
CH] net/tap: remove queue specific offload >> support >> >> Hi Ferruh, >> I was able to apply your patch with Thomas help: >> 1. git am --reject >> 2. >> 3. git am --continue >> >> Regards, >> Ophir >> >>> -Original Message

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-23 Thread Ophir Munk
ril 23, 2018 11:39 AM > To: 'Ferruh Yigit' ; Thomas Monjalon > ; Pascal Mazon ; > Mordechay Haimovsky > Cc: 'dev@dpdk.org' ; Shahaf Shuler > ; Olga Shern ; Raslan > Darawsheh > Subject: RE: [dpdk-dev] [PATCH] net/tap: remove queue specific offload > support &

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-23 Thread Ophir Munk
imovsky > Cc: dev@dpdk.org; Shahaf Shuler ; Olga Shern > ; Raslan Darawsheh > Subject: RE: [dpdk-dev] [PATCH] net/tap: remove queue specific offload > support > > Hi Ferruh, > I am not able to apply your patch on next-net/master branch. > I am failing to apply it both

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-22 Thread Ophir Munk
t; >> Sent: Wednesday, April 18, 2018 11:59 AM > >> To: Thomas Monjalon ; Pascal Mazon > >> ; Mordechay Haimovsky > ; > >> Ophir Munk > >> Cc: dev@dpdk.org; Shahaf Shuler ; Olga Shern > >> > >> Subject: Re: [dpdk-dev] [PATCH] net/tap: rem

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-18 Thread Ferruh Yigit
>> Cc: dev@dpdk.org; Shahaf Shuler ; Olga Shern >> >> Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload >> support >> >> On 4/12/2018 5:23 PM, Ferruh Yigit wrote: >>> On 4/5/2018 6:49 PM, Thomas Monjalon wrote: >>>> Pascal

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-18 Thread Ophir Munk
April 18, 2018 11:59 AM > To: Thomas Monjalon ; Pascal Mazon > ; Mordechay Haimovsky > ; Ophir Munk > Cc: dev@dpdk.org; Shahaf Shuler ; Olga Shern > > Subject: Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload > support > > On 4/12/2018 5:23 PM, Ferruh Yigit wr

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-18 Thread Ferruh Yigit
On 4/12/2018 5:23 PM, Ferruh Yigit wrote: > On 4/5/2018 6:49 PM, Thomas Monjalon wrote: >> Pascal, Moti, Ophir, >> please comment. > > Hi Moti, > > Any comment? This has been asked many times now. Hi Moti, Ophir, You have not responded why queue specific offload added in other thread. And you a

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-12 Thread Ferruh Yigit
On 4/5/2018 6:49 PM, Thomas Monjalon wrote: > Pascal, Moti, Ophir, > please comment. Hi Moti, Any comment? This has been asked many times now. > > 22/03/2018 19:28, Ferruh Yigit: >> It is not clear if tap PMD supports queue specific offloads, removing >> the related code. >> >> Fixes: 95ae196ae

Re: [dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-04-05 Thread Thomas Monjalon
Pascal, Moti, Ophir, please comment. 22/03/2018 19:28, Ferruh Yigit: > It is not clear if tap PMD supports queue specific offloads, removing > the related code. > > Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") > Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") > Cc: mo...@mell

[dpdk-dev] [PATCH] net/tap: remove queue specific offload support

2018-03-22 Thread Ferruh Yigit
It is not clear if tap PMD supports queue specific offloads, removing the related code. Fixes: 95ae196ae10b ("net/tap: use new Rx offloads API") Fixes: 818fe14a9891 ("net/tap: use new Tx offloads API") Cc: mo...@mellanox.com Signed-off-by: Ferruh Yigit --- Cc: Shahaf Shuler --- drivers/net/tap