Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-18 Thread Ye Xiaolong
On 04/19, Liu, Yong wrote: >Sorry for missed this question. The purpose of change function is to skip >device initialization which is not needed in configuration stage. >When features not matched, can just do feature negotiation in configuration >stage and do related actions when virtio device

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-18 Thread Liu, Yong
Sorry for missed this question. The purpose of change function is to skip device initialization which is not needed in configuration stage. When features not matched, can just do feature negotiation in configuration stage and do related actions when virtio device start. Regards, Marvin >

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-17 Thread Maxime Coquelin
Hi Marvin, On 4/15/20 9:30 AM, Liu, Yong wrote: >> @@ -2120,7 +2119,7 @@ virtio_dev_configure(struct rte_eth_dev *dev) >> >> /* if request features changed, reinit the device */ >> if (req_features != hw->req_guest_features) { >> -ret = virtio_init_device(dev, req_features);

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-15 Thread Liu, Yong
> -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, April 15, 2020 3:24 PM > To: Liu, Yong > Cc: maxime.coque...@redhat.com; Wang, Zhihong > ; dev@dpdk.org; Ding, Xuan > > Subject: Re: [PATCH] net/virtio: fix crash when device reconnecting > > Hi, Marvin > > On 04/14, Marvi

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-15 Thread Ye Xiaolong
Hi, Marvin On 04/14, Marvin Liu wrote: >When doing virtio device initialization, virtqueues will be reset in >server mode if ring type is packed. This will cause issue because queues >have been freed in the beginning of device initialization. > >Fix this issue by splitting device initial process a

Re: [dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-14 Thread Wang, Yinan
Tested-by: Wang, Yinan > -Original Message- > From: dev On Behalf Of Marvin Liu > Sent: 2020年4月14日 20:56 > To: maxime.coque...@redhat.com; Wang, Zhihong ; > Ye, Xiaolong > Cc: dev@dpdk.org; Ding, Xuan ; Liu, Yong > > Subject: [dpdk-dev] [PATCH] net/virti

[dpdk-dev] [PATCH] net/virtio: fix crash when device reconnecting

2020-04-13 Thread Marvin Liu
When doing virtio device initialization, virtqueues will be reset in server mode if ring type is packed. This will cause issue because queues have been freed in the beginning of device initialization. Fix this issue by splitting device initial process and device reinit process. Virt queues won't b