Re: [dpdk-dev] [PATCH] pipeline: remove unreachable branch

2021-11-04 Thread Thomas Monjalon
> > A previous change blamed it on compiler/ASan, while this is a real > > (yet minor) issue. > > > > This return -EINVAL is never reached since we test all combinations of > > fidx and fcin booleans. > > All branches end up with a return 0, factorize them. > > > > Fixes: 84f5ac9418ea ("pipeline:

Re: [dpdk-dev] [PATCH] pipeline: remove unreachable branch

2021-11-03 Thread Dumitrescu, Cristian
> -Original Message- > From: David Marchand > Sent: Wednesday, November 3, 2021 6:57 AM > To: dev@dpdk.org > Cc: Dumitrescu, Cristian ; Lin, Xueqin > ; Peng, ZhihongX > Subject: [PATCH] pipeline: remove unreachable branch > > A previous change blamed it on compiler/ASan, while this is

[dpdk-dev] [PATCH] pipeline: remove unreachable branch

2021-11-02 Thread David Marchand
A previous change blamed it on compiler/ASan, while this is a real (yet minor) issue. This return -EINVAL is never reached since we test all combinations of fidx and fcin booleans. All branches end up with a return 0, factorize them. Fixes: 84f5ac9418ea ("pipeline: fix build with ASan") Fixes: f3