Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-11-13 Thread Tan, Jianfeng
Hi Sebastian, The title can be refined as: net/virtio-user: fix unchecked return value Other than the above comment, it seems good to me. On 11/13/2017 9:38 PM, SebastianX Basierski wrote: Report error message if clearing O_NONBLOCK flag will fail, then return from function. Coverity iss

[dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-11-13 Thread SebastianX Basierski
Report error message if clearing O_NONBLOCK flag will fail, then return from function. Coverity issue: 143439 Fixes: ef53b6030039 ("net/virtio-user: support LSC") Cc: jianfeng@intel.com Cc: y...@fridaylinux.org cc: dev@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/virtio/vir

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-10-16 Thread Tan, Jianfeng
Hi Sebastian, Sorry for the late response. I missed the previous emails. On 10/16/2017 4:32 PM, Basierski, SebastianX wrote: flags = fcntl(dev->vhostfd, F_GETFL); - fcntl(dev->vhostfd, F_SETFL, flags | O_NONBLOCK); + if (fcntl(

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-10-16 Thread Basierski, SebastianX
-Original Message- From: Basierski, SebastianX Sent: Friday, September 29, 2017 9:44 AM To: Tan, Jianfeng ; skh...@vmware.com Cc: dev@dpdk.org Subject: RE: [PATCH] pmd_virtio: Unchecked return value from library -Original Message- From: Tan, Jianfeng Sent: Wednesday, September

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-29 Thread Basierski, SebastianX
-Original Message- From: Tan, Jianfeng Sent: Wednesday, September 20, 2017 2:56 AM To: Basierski, SebastianX ; skh...@vmware.com Cc: dev@dpdk.org Subject: RE: [PATCH] pmd_virtio: Unchecked return value from library Hi, Thank you for those fixes. > -Original Message- > From: Ba

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-20 Thread Basierski, SebastianX
Hi, Thank you for those fixes. > -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:47 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Unchecked return value from library > > Check retu

Re: [dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-19 Thread Tan, Jianfeng
Hi, Thank you for those fixes. > -Original Message- > From: Basierski, SebastianX > Sent: Tuesday, September 19, 2017 7:47 PM > To: skh...@vmware.com > Cc: Basierski, SebastianX; Tan, Jianfeng; dev@dpdk.org > Subject: [PATCH] pmd_virtio: Unchecked return value from library > > Check retu

[dpdk-dev] [PATCH] pmd_virtio: Unchecked return value from library

2017-09-19 Thread SebastianX Basierski
Check return value from library in order to prevent potential fail. Coverity issue: 143439 Fixes: ef53b6030039 ("net/virtio-user: support LSC") Cc: jianfeng@intel.com cc: dev@dpdk.org Signed-off-by: SebastianX Basierski --- drivers/net/virtio/virtio_user_ethdev.c | 10 -- 1 file ch