Re: [dpdk-dev] [PATCH] rcu: avoid literal suffix warning in C++ mode

2020-09-03 Thread Honnappa Nagarahalli
Hi Dmitry, Thanks for the patch, few nits inline. > -Original Message- > From: Dmitry Kozlyuk > Sent: Monday, August 31, 2020 4:38 PM > To: dev@dpdk.org > Cc: Dmitry Kozlyuk ; sta...@dpdk.org; > Honnappa Nagarahalli > Subject: [PATCH] rcu: avoid literal suffix warning in C++ mode

[dpdk-dev] [PATCH] rcu: avoid literal suffix warning in C++ mode

2020-08-31 Thread Dmitry Kozlyuk
Sequences like "value = %"PRIu64 (no space before PRIu64) are parsed as a single preprocessor token, user-defined-string-literal, in C++11 onwards. While modern compilers are smart enough to parse this properly, GCC 9.3.0 generates warnings like: rte_rcu_qsbr.h:555:26: warning: invalid suffix