On Fri, Nov 28, 2014 at 3:59 PM, Bruce Richardson <
bruce.richardson at intel.com> wrote:
> Yes, it's ugly, but it's probably more resilient. I'm looking forward to
> getting
> an option C.
>
Option C and D are ugly as well (using some bashism like $' ' or using an
intermediate variable with a ne
On Fri, Nov 28, 2014 at 3:43 PM, Bruce Richardson <
bruce.richardson at intel.com> wrote:
> This proposed fix also works. I don't mind whether my patch proposal or
> this
> fix gets applied - gen-config-h.sh is not a commonly modified script
> anyway.
>
I prefer my ugliness ;-)
But Thomas just pr
Hello Bruce,
On Fri, Nov 28, 2014 at 2:56 PM, Bruce Richardson <
bruce.richardson at intel.com> wrote:
> On Thu, Nov 27, 2014 at 10:17:22AM -0800, Thomas Monjalon wrote:
> > > When redefining the same symbol in configuration (basically after an
> inclusion),
> > > we need to undefine the previous
On Fri, Nov 28, 2014 at 03:49:29PM +0100, David Marchand wrote:
> On Fri, Nov 28, 2014 at 3:43 PM, Bruce Richardson <
> bruce.richardson at intel.com> wrote:
>
> > This proposed fix also works. I don't mind whether my patch proposal or
> > this
> > fix gets applied - gen-config-h.sh is not a commo
On Fri, Nov 28, 2014 at 03:06:11PM +0100, David Marchand wrote:
> Hello Bruce,
>
> On Fri, Nov 28, 2014 at 2:56 PM, Bruce Richardson <
> bruce.richardson at intel.com> wrote:
>
> > On Thu, Nov 27, 2014 at 10:17:22AM -0800, Thomas Monjalon wrote:
> > > > When redefining the same symbol in configur
On Fri, Nov 28, 2014 at 03:06:11PM +0100, David Marchand wrote:
> Hello Bruce,
>
> On Fri, Nov 28, 2014 at 2:56 PM, Bruce Richardson <
> bruce.richardson at intel.com> wrote:
>
> > On Thu, Nov 27, 2014 at 10:17:22AM -0800, Thomas Monjalon wrote:
> > > > When redefining the same symbol in configur
On Thu, Nov 27, 2014 at 10:17:22AM -0800, Thomas Monjalon wrote:
> > When redefining the same symbol in configuration (basically after an
> > inclusion),
> > we need to undefine the previous symbol to avoid "redefined" errors.
> >
> > Signed-off-by: David Marchand
>
> Acked-by: Thomas Monjalon
On Thu, Nov 27, 2014 at 12:29:05PM +0100, David Marchand wrote:
> When redefining the same symbol in configuration (basically after an
> inclusion),
> we need to undefine the previous symbol to avoid "redefined" errors.
>
> Signed-off-by: David Marchand
Though I see this patch is already replie
When redefining the same symbol in configuration (basically after an inclusion),
we need to undefine the previous symbol to avoid "redefined" errors.
Signed-off-by: David Marchand
---
scripts/gen-config-h.sh | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/scrip
> When redefining the same symbol in configuration (basically after an
> inclusion),
> we need to undefine the previous symbol to avoid "redefined" errors.
>
> Signed-off-by: David Marchand
Acked-by: Thomas Monjalon
Applied
Thanks
--
Thomas
10 matches
Mail list logo
