Re: [dpdk-dev] [PATCH] service: fix wrong lcore indexes

2020-07-06 Thread Andrew Rybchenko
On 7/4/20 6:10 PM, David Marchand wrote: > On Sat, Jul 4, 2020 at 5:07 PM Honnappa Nagarahalli > wrote: >> >> Hi Andrew/Igor, >> A effective test case is missing for this, can you please add a test >> case? Otherwise it looks good. > > +1, I was about to reply this. Done in v2

Re: [dpdk-dev] [PATCH] service: fix wrong lcore indexes

2020-07-04 Thread David Marchand
On Sat, Jul 4, 2020 at 5:07 PM Honnappa Nagarahalli wrote: > > Hi Andrew/Igor, > A effective test case is missing for this, can you please add a test > case? Otherwise it looks good. +1, I was about to reply this. -- David Marchand

Re: [dpdk-dev] [PATCH] service: fix wrong lcore indexes

2020-07-04 Thread Honnappa Nagarahalli
sta...@dpdk.org; Harry van > Haaren > Subject: [dpdk-dev] [PATCH] service: fix wrong lcore indexes Nit, 'indices' would be better? ^^^ > > From: Igor Romanov > > The service core list is populated, but not used. Incorrec

[dpdk-dev] [PATCH] service: fix wrong lcore indexes

2020-07-04 Thread Andrew Rybchenko
From: Igor Romanov The service core list is populated, but not used. Incorrect lcore states are examined for a service. Use the populated list to iterate over service cores. Fixes: e30dd31847d2 ("service: add mechanism for quiescing") Cc: sta...@dpdk.org Signed-off-by: Igor Romanov Signed-off