Re: [dpdk-dev] [PATCH] telemetry: fix accessing callbacks list using lock

2021-05-05 Thread David Marchand
On Wed, May 5, 2021 at 5:36 PM Bruce Richardson wrote: > > On Wed, May 05, 2021 at 03:22:48PM +, Ciara Power wrote: > > The list_commands() function accessed the callbacks list, > > but did not take the lock. This may have caused inconsistencies if > > callbacks were being registered at the sa

Re: [dpdk-dev] [PATCH] telemetry: fix accessing callbacks list using lock

2021-05-05 Thread Bruce Richardson
On Wed, May 05, 2021 at 03:22:48PM +, Ciara Power wrote: > The list_commands() function accessed the callbacks list, > but did not take the lock. This may have caused inconsistencies if > callbacks were being registered at the same time. > This is now fixed to lock before iterating the list, >

[dpdk-dev] [PATCH] telemetry: fix accessing callbacks list using lock

2021-05-05 Thread Ciara Power
The list_commands() function accessed the callbacks list, but did not take the lock. This may have caused inconsistencies if callbacks were being registered at the same time. This is now fixed to lock before iterating the list, and unlock afterwards. Fixes: f38748736eb2 ("telemetry: add default ca