Fixes: a4b7a5a45cf5 ("timer: fix race condition")
2016-07-25 23:43 GMT+09:00 Thomas Monjalon :
> Hiroyuki, Robert,
> I would like to apply these patches quickly.
> Please could you provide some "Fixes:" line to know the origin
> of the bugs?
> Thanks
>
Hi Robert,
My application had timers which reset another timer and sometimes did not work.
Its profile by 'perf' command showed timer_add occupied 99.9% CPU. It
seemed that an infinite loop occurred in rte_timer.
I inspected timer codes and found that the main cause was a bug of the
patch 3. In th
> >When timer_cb resets another running timer on the same lcore,
> >the list of expired timers is chained to the pending-list.
> >This commit prevents a running timer from being reset
> >by not its own timer_cb.
> >
> >Signed-off-by: Hiroyuki Mikita
>
> Acked-by: Robert Sanford
>
> I tested the
2016-07-26 00:14, Hiroyuki Mikita:
> Fixes: a4b7a5a45cf5 ("timer: fix race condition")
>
> 2016-07-25 23:43 GMT+09:00 Thomas Monjalon :
> > Hiroyuki, Robert,
> > I would like to apply these patches quickly.
> > Please could you provide some "Fixes:" line to know the origin
> > of the bugs?
> > Tha
Hiroyuki, Robert,
I would like to apply these patches quickly.
Please could you provide some "Fixes:" line to know the origin
of the bugs?
Thanks
On 7/23/16 4:49 AM, "Thomas Monjalon" wrote:
>2016-07-23 0:14 GMT+02:00 Sanford, Robert :
>> Acked-by: Robert Sanford
>>
>> I tested the three timer patches with app/test timer_autotest and
>> timer_racecond_autotest, and additional private tests.
>
>Thanks Robert.
>Are you confident enough to
2016-07-23 0:14 GMT+02:00 Sanford, Robert :
> Acked-by: Robert Sanford
>
> I tested the three timer patches with app/test timer_autotest and
> timer_racecond_autotest, and additional private tests.
Thanks Robert.
Are you confident enough to integrate them in the last days of 16.07?
How critical a
On 7/17/16 2:08 PM, "Hiroyuki Mikita" wrote:
>When timer_cb resets another running timer on the same lcore,
>the list of expired timers is chained to the pending-list.
>This commit prevents a running timer from being reset
>by not its own timer_cb.
>
>Signed-off-by: Hiroyuki Mikita
>---
> lib/
Hi Robert,
Thank you for reviewing.
In the following case, the skip list is broken.
- Timer A and timer B are configured on the same lcore, in the same
pending list.
- The expire time of timer A is earlier than that of timer B.
- rte_timer_manage() is called on the lcore after the expire time of
Hi Hiroyuki,
I am reviewing your 3 timer patches.
Can you please explain in more detail your use-case that results in a
problem?
For example, is it when timer A's callback tries to reset
(rte_timer_reset) timer B?
If yes, is timer B in PENDING state and likely to expire soon?
--
Thanks,
Robert
When timer_cb resets another running timer on the same lcore,
the list of expired timers is chained to the pending-list.
This commit prevents a running timer from being reset
by not its own timer_cb.
Signed-off-by: Hiroyuki Mikita
---
lib/librte_timer/rte_timer.c | 12 ++--
1 file change
11 matches
Mail list logo
