Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-21 Thread Bruce Richardson
On Fri, Oct 18, 2019 at 09:08:25AM -0700, Stephen Hemminger wrote: > On Fri, 18 Oct 2019 17:56:48 +0200 > Robin Jarry wrote: > > > 2019-10-18, Stephen Hemminger: > > > Why not add this (since git doesn't like trailing whitespace). > > > > > > trim_trailing_whitespace=true > > > > Because Edit

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2019 17:56:48 +0200 Robin Jarry wrote: > 2019-10-18, Stephen Hemminger: > > Why not add this (since git doesn't like trailing whitespace). > > > > trim_trailing_whitespace=true > > Because EditorConfig applies the setting to the whole file when saving. > This has chances of tri

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Robin Jarry
2019-10-18, Stephen Hemminger: > Why not add this (since git doesn't like trailing whitespace). > > trim_trailing_whitespace=true Because EditorConfig applies the setting to the whole file when saving. This has chances of trimming white space on lines that you did not modify. I figure this is not

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Robin Jarry
2019-10-18, Stephen Hemminger: > In the example on web site, they use > [*.py] not [**.py] I've tested both forms, they work the same. I don't have a strong opinion on this, I can change to [*.py]. -- Robin

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2019 09:59:54 +0200 Robin Jarry wrote: > diff --git a/.editorconfig b/.editorconfig > new file mode 100644 > index ..c5704d89b8c6 > --- /dev/null > +++ b/.editorconfig > @@ -0,0 +1,23 @@ > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2019 6WIND S.A. > + > +ro

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Stephen Hemminger
On Fri, 18 Oct 2019 09:59:54 +0200 Robin Jarry wrote: Looks good, you should add a reference to https://editorconfig.org so others understand this > +# SPDX-License-Identifier: BSD-3-Clause > +# Copyright 2019 6WIND S.A. > + > +root = true > + > +[*] > +end_of_line = lf > +insert_final_newline =

Re: [dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Burakov, Anatoly
On 18-Oct-19 8:59 AM, Robin Jarry wrote: EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in doc/guides/contributing/coding_style.rst, doc/guides/contrib

[dpdk-dev] [PATCH] tools: add EditorConfig file

2019-10-18 Thread Robin Jarry
EditorConfig is a file format and collection of text editor plugins for maintaining consistent coding styles between different editors and IDEs. Initialize the file following the coding rules in doc/guides/contributing/coding_style.rst, doc/guides/contributing/documentation.rst and doc/guides/cont