Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison

2020-05-04 Thread Maxime Coquelin
On 5/4/20 9:12 AM, Matan Azrad wrote: > A regular memcmp function was used to compare between two objects of > type `struct rte_pci_addr`. > > Due to the alignment rules of compiler structure builders, some memory > is not initiated in the structure even though all the fields were > initiated.

Re: [dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison

2020-05-04 Thread Maxime Coquelin
On 5/4/20 9:12 AM, Matan Azrad wrote: > A regular memcmp function was used to compare between two objects of > type `struct rte_pci_addr`. > > Due to the alignment rules of compiler structure builders, some memory > is not initiated in the structure even though all the fields were > initiated.

[dpdk-dev] [PATCH] vdpa/mlx5: fix PCI address comparison

2020-05-04 Thread Matan Azrad
A regular memcmp function was used to compare between two objects of type `struct rte_pci_addr`. Due to the alignment rules of compiler structure builders, some memory is not initiated in the structure even though all the fields were initiated. Therefore, the comparison may fail even though the P