Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-12 Thread Ilya Maximets
On 12.04.2019 7:39, Tiwei Bie wrote: > On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote: >> Application should be able to obtain information like 'ifname' from >> the 'vid' passed to 'destroy_connection' callback. Currently, all the >> API calls with passed 'vid' fails with 'device not

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-11 Thread Tiwei Bie
On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote: > Application should be able to obtain information like 'ifname' from > the 'vid' passed to 'destroy_connection' callback. Currently, all the > API calls with passed 'vid' fails with 'device not found'. > > Fixes: efba12a78ddf ("vhost:

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-11 Thread Ilya Maximets
On 10.04.2019 11:07, David Marchand wrote: > On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets > wrote: > > On 10.04.2019 10:24, David Marchand wrote: > > For vhost maintainers, looking at vhost_user_add_connection, aren't we > leaking a vid on errors ? either

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-10 Thread David Marchand
On Wed, Apr 10, 2019 at 9:53 AM Ilya Maximets wrote: > On 10.04.2019 10:24, David Marchand wrote: > > For vhost maintainers, looking at vhost_user_add_connection, aren't we > leaking a vid on errors ? either when new_connection notifier returns an > error, or after calling destroy_connection. > >

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-10 Thread Ilya Maximets
On 10.04.2019 10:24, David Marchand wrote: > > > On Tue, Apr 9, 2019 at 3:36 PM Ilya Maximets > wrote: > > Application should be able to obtain information like 'ifname' from > the 'vid' passed to 'destroy_connection' callback. Currently, all the > API

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-10 Thread David Marchand
On Tue, Apr 9, 2019 at 3:36 PM Ilya Maximets wrote: > Application should be able to obtain information like 'ifname' from > the 'vid' passed to 'destroy_connection' callback. Currently, all the > API calls with passed 'vid' fails with 'device not found'. > > Fixes: efba12a78ddf ("vhost: add user

Re: [dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-09 Thread Jens Freimann
On Tue, Apr 09, 2019 at 04:36:22PM +0300, Ilya Maximets wrote: Application should be able to obtain information like 'ifname' from the 'vid' passed to 'destroy_connection' callback. Currently, all the API calls with passed 'vid' fails with 'device not found'. Fixes: efba12a78ddf ("vhost: add use

[dpdk-dev] [PATCH] vhost: fix passing destroyed device to destroy callback

2019-04-09 Thread Ilya Maximets
Application should be able to obtain information like 'ifname' from the 'vid' passed to 'destroy_connection' callback. Currently, all the API calls with passed 'vid' fails with 'device not found'. Fixes: efba12a78ddf ("vhost: add user callbacks for socket open/close") Cc: sta...@dpdk.org Signed-o