The current implementation of vhost_net in packed vring tries to fill
the shadow vector before send any actual changes to the guest. While
this can be beneficial for the throughput, it conflicts with some
bufferfloats methods like the linux kernel napi, that stops
transmitting packets if there are
Hi Eugenio,
On 29/01/2020 19:33, Eugenio Pérez wrote:
> The current implementation of vhost_net in packed vring tries to fill
> the shadow vector before send any actual changes to the guest. While
> this can be beneficial for the throughput, it conflicts with some
> bufferfloats methods like the l
Hi Kevin!
Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: optimize
packed ring dequeue"), what was not present on 18.11 version (I've checked
that v19.08 does not contain the failure).
Do I need to send another patch version with corrected commit message?
Thanks!
On Fri, Jan 3
On 04/02/2020 09:23, Eugenio Perez Martin wrote:
> Hi Kevin!
>
> Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: optimize
> packed ring dequeue"), what was not present on 18.11 version (I've checked
> that v19.08 does not contain the failure).
>
Right, in that case the issue is
Ouch, my bad again, sorry :).
I've forwarded the patch to stable@, please let me know if I need to do
something else.
Maxime, please let me know if I need to send a new version with the "Fixed:
" tag :).
Thanks!
On Tue, Feb 4, 2020 at 2:49 PM Kevin Traynor wrote:
> On 04/02/2020 09:23, Eugeni
On 2/4/20 4:05 PM, Eugenio Perez Martin wrote:
> Ouch, my bad again, sorry :).
>
> I've forwarded the patch to stable@, please let me know if I need to do
> something else.
>
> Maxime, please let me know if I need to send a new version with the "Fixed:
> " tag :).
Not needed, I will handle it
On 2/4/20 3:47 PM, Eugenio Pérez wrote:
> The current implementation of vhost_net in packed vring tries to fill
> the shadow vector before send any actual changes to the guest. While
> this can be beneficial for the throughput, it conflicts with some
> bufferfloats methods like the linux kernel
On 2/4/20 3:47 PM, Eugenio Pérez wrote:
> The current implementation of vhost_net in packed vring tries to fill
> the shadow vector before send any actual changes to the guest. While
> this can be beneficial for the throughput, it conflicts with some
> bufferfloats methods like the linux kernel
Thanks!
On Wed, Feb 5, 2020 at 10:48 AM Maxime Coquelin
wrote:
>
>
> On 2/4/20 3:47 PM, Eugenio Pérez wrote:
> > The current implementation of vhost_net in packed vring tries to fill
> > the shadow vector before send any actual changes to the guest. While
> > this can be beneficial for the throu
9 matches
Mail list logo