[dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-01-29 Thread Eugenio Pérez
The current implementation of vhost_net in packed vring tries to fill the shadow vector before send any actual changes to the guest. While this can be beneficial for the throughput, it conflicts with some bufferfloats methods like the linux kernel napi, that stops transmitting packets if there are

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-01-31 Thread Kevin Traynor
Hi Eugenio, On 29/01/2020 19:33, Eugenio Pérez wrote: > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this can be beneficial for the throughput, it conflicts with some > bufferfloats methods like the l

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Eugenio Perez Martin
Hi Kevin! Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: optimize packed ring dequeue"), what was not present on 18.11 version (I've checked that v19.08 does not contain the failure). Do I need to send another patch version with corrected commit message? Thanks! On Fri, Jan 3

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Kevin Traynor
On 04/02/2020 09:23, Eugenio Perez Martin wrote: > Hi Kevin! > > Sorry, thanks for noticing it! It fixes commit ("31d6c6a5b vhost: optimize > packed ring dequeue"), what was not present on 18.11 version (I've checked > that v19.08 does not contain the failure). > Right, in that case the issue is

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Eugenio Perez Martin
Ouch, my bad again, sorry :). I've forwarded the patch to stable@, please let me know if I need to do something else. Maxime, please let me know if I need to send a new version with the "Fixed: " tag :). Thanks! On Tue, Feb 4, 2020 at 2:49 PM Kevin Traynor wrote: > On 04/02/2020 09:23, Eugeni

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-04 Thread Maxime Coquelin
On 2/4/20 4:05 PM, Eugenio Perez Martin wrote: > Ouch, my bad again, sorry :). > > I've forwarded the patch to stable@, please let me know if I need to do > something else. > > Maxime, please let me know if I need to send a new version with the "Fixed: > " tag :). Not needed, I will handle it

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Maxime Coquelin
On 2/4/20 3:47 PM, Eugenio Pérez wrote: > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this can be beneficial for the throughput, it conflicts with some > bufferfloats methods like the linux kernel

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Maxime Coquelin
On 2/4/20 3:47 PM, Eugenio Pérez wrote: > The current implementation of vhost_net in packed vring tries to fill > the shadow vector before send any actual changes to the guest. While > this can be beneficial for the throughput, it conflicts with some > bufferfloats methods like the linux kernel

Re: [dpdk-dev] [PATCH] vhost: flush shadow tx if there is no more packets

2020-02-05 Thread Eugenio Perez Martin
Thanks! On Wed, Feb 5, 2020 at 10:48 AM Maxime Coquelin wrote: > > > On 2/4/20 3:47 PM, Eugenio Pérez wrote: > > The current implementation of vhost_net in packed vring tries to fill > > the shadow vector before send any actual changes to the guest. While > > this can be beneficial for the throu