Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-16 Thread Maxime Coquelin
On 05/16/2018 08:10 AM, Tiwei Bie wrote: On Tue, May 15, 2018 at 03:50:54PM +0200, Maxime Coquelin wrote: Hi Tiwei, I just see I missed to reply to your comment on my commit message: On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: T

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-15 Thread Tiwei Bie
On Tue, May 15, 2018 at 03:50:54PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > I just see I missed to reply to your comment on my commit message: > > On 05/03/2018 01:56 PM, Tiwei Bie wrote: > > On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: > > > This patch caches all dirty p

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-15 Thread Maxime Coquelin
Hi Tiwei, I just see I missed to reply to your comment on my commit message: On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be acce

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-06 Thread Michael S. Tsirkin
On Mon, May 07, 2018 at 11:49:49AM +0800, Tiwei Bie wrote: > On Fri, May 04, 2018 at 05:48:05PM +0200, Maxime Coquelin wrote: > > Hi Tiwei, > > > > On 05/03/2018 01:56 PM, Tiwei Bie wrote: > > > On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: > [...] > > > > +static __rte_always_i

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-06 Thread Tiwei Bie
On Fri, May 04, 2018 at 05:48:05PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > On 05/03/2018 01:56 PM, Tiwei Bie wrote: > > On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: [...] > > > +static __rte_always_inline void > > > +vhost_log_cache_sync(struct virtio_net *dev, struct vho

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-04 Thread Michael S. Tsirkin
On Fri, May 04, 2018 at 05:48:05PM +0200, Maxime Coquelin wrote: > Hi Tiwei, > > On 05/03/2018 01:56 PM, Tiwei Bie wrote: > > On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: > > > This patch caches all dirty pages logging until the used ring index > > > is updated. These dirty pag

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-04 Thread Maxime Coquelin
Hi Tiwei, On 05/03/2018 01:56 PM, Tiwei Bie wrote: On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it b

Re: [dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-05-03 Thread Tiwei Bie
On Mon, Apr 30, 2018 at 05:59:54PM +0200, Maxime Coquelin wrote: > This patch caches all dirty pages logging until the used ring index > is updated. These dirty pages won't be accessed by the guest as > long as the host doesn't give them back to it by updating the > index. Below sentence in above

[dpdk-dev] [PATCH] vhost: improve dirty pages logging performance

2018-04-30 Thread Maxime Coquelin
This patch caches all dirty pages logging until the used ring index is updated. These dirty pages won't be accessed by the guest as long as the host doesn't give them back to it by updating the index. The goal of this optimization is to fix a performance regression introduced when the vhost librar