[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-09 Thread Michael S. Tsirkin
On Fri, Oct 30, 2015 at 06:48:09PM +0100, Thomas Monjalon wrote: > 2015-10-18 10:04, Michael S. Tsirkin: > > On Fri, Oct 16, 2015 at 02:52:30PM +0100, Bruce Richardson wrote: > > > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > > > On Thu, Oct 15, 2015 at 02:08:39PM +0300,

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Marcel Apfelbaum
On 11/03/2015 10:16 AM, Xie, Huawei wrote: > On 11/3/2015 4:03 PM, Marcel Apfelbaum wrote: >> On 11/03/2015 05:49 AM, Xu, Qian Q wrote: >>> Sorry, correct the kernel info, my kernel version is >>> 4.1.8-100.fc21.x86_64. >> >> Hi, >> >> This is weird, VIRTIO_F_VERSION_1 is defined in 4.0 (I think),

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Marcel Apfelbaum
On 11/03/2015 10:26 AM, Thomas Monjalon wrote: > 2015-11-03 08:16, Xie, Huawei: >> On 11/3/2015 4:03 PM, Marcel Apfelbaum wrote: >>> On 11/03/2015 05:49 AM, Xu, Qian Q wrote: Sorry, correct the kernel info, my kernel version is 4.1.8-100.fc21.x86_64. >>> >>> Hi, >>> >>> This is weird,

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Marcel Apfelbaum
t; To: Thomas Monjalon; Marcel Apfelbaum > Cc: dev at dpdk.org; Michael S. Tsirkin > Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 > > DPDK GCC 64bit build on kernel 3.18 will be failed, could you help check? > > == Build lib/librte_pipeline > /home/qxu10/virtio

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Thomas Monjalon
2015-11-03 08:16, Xie, Huawei: > On 11/3/2015 4:03 PM, Marcel Apfelbaum wrote: > > On 11/03/2015 05:49 AM, Xu, Qian Q wrote: > >> Sorry, correct the kernel info, my kernel version is > >> 4.1.8-100.fc21.x86_64. > > > > Hi, > > > > This is weird, VIRTIO_F_VERSION_1 is defined in 4.0 (I think), and

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Xie, Huawei
On 11/3/2015 4:03 PM, Marcel Apfelbaum wrote: > On 11/03/2015 05:49 AM, Xu, Qian Q wrote: >> Sorry, correct the kernel info, my kernel version is >> 4.1.8-100.fc21.x86_64. > > Hi, > > This is weird, VIRTIO_F_VERSION_1 is defined in 4.0 (I think), and for > sure in 4.1 . > You can see commit

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Xu, Qian Q
. Tsirkin Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 DPDK GCC 64bit build on kernel 3.18 will be failed, could you help check? == Build lib/librte_pipeline /home/qxu10/virtio-opt-test/dpdk/lib/librte_vhost/virtio-net.c:81:106: error: 'VIRTIO_F_VERSION_1' undeclared here

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-03 Thread Xu, Qian Q
, November 03, 2015 6:14 AM To: Marcel Apfelbaum Cc: dev at dpdk.org; Michael S. Tsirkin Subject: Re: [dpdk-dev] [PATCH] vhost-user: enable virtio 1.0 > > Make vhost-user virtio 1.0 compatible by adding it to the supported > > features and keeping the header length the same as for

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-02 Thread Thomas Monjalon
> > Make vhost-user virtio 1.0 compatible by adding it to the > > supported features and keeping the header length > > the same as for mergeable RX buffers. > > > > Signed-off-by: Marcel Apfelbaum > > Looks good to me > > Acked-by: Michael S. Tsirkin Applied, thanks

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-01 Thread Marcel Apfelbaum
On 11/01/2015 11:53 AM, Thomas Monjalon wrote: > 2015-11-01 11:00, Marcel Apfelbaum: >> On 10/30/2015 07:48 PM, Thomas Monjalon wrote: >>> 2015-10-18 10:04, Michael S. Tsirkin: This will require more work then as 1.0 is a different endian-ness from 0.9. It's up to you guys to decide

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-01 Thread Marcel Apfelbaum
On 10/30/2015 07:48 PM, Thomas Monjalon wrote: > 2015-10-18 10:04, Michael S. Tsirkin: >> On Fri, Oct 16, 2015 at 02:52:30PM +0100, Bruce Richardson wrote: >>> On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote:

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-11-01 Thread Thomas Monjalon
2015-11-01 11:00, Marcel Apfelbaum: > On 10/30/2015 07:48 PM, Thomas Monjalon wrote: > > 2015-10-18 10:04, Michael S. Tsirkin: > >> This will require more work then as 1.0 is a different > >> endian-ness from 0.9. It's up to you guys to decide > >> whether correct BE support is now a requirement

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-30 Thread Thomas Monjalon
2015-10-18 10:04, Michael S. Tsirkin: > On Fri, Oct 16, 2015 at 02:52:30PM +0100, Bruce Richardson wrote: > > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > > > Make vhost-user virtio 1.0 compatible by

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-18 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 02:52:30PM +0100, Bruce Richardson wrote: > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > > Make vhost-user virtio 1.0 compatible by adding it to the > > > supported features and

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 09:43:09AM +0200, Andriy Berestovskyy wrote: > Hi guys, > Just a minor note: ARM is bi-endian in fact. Thank you for clarifying that my old memory is right :) --yliu > For instance, there are > both endians tool chains available on Linaro. > > Andriy > > > On

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Bruce Richardson
On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > Make vhost-user virtio 1.0 compatible by adding it to the > > supported features and keeping the header length > > the same as for mergeable RX buffers. > >

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Yuanhan Liu
On Fri, Oct 16, 2015 at 09:20:18AM +0300, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 10:24:38AM +0800, Yuanhan Liu wrote: > > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > > > Make vhost-user

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 09:43:09AM +0200, Andriy Berestovskyy wrote: > Hi guys, > Just a minor note: ARM is bi-endian in fact. For instance, there are > both endians tool chains available on Linaro. > > Andriy Yea. BE support is around for legacy stuff. So I'm not sure it's all that important

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Yuanhan Liu
On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > Make vhost-user virtio 1.0 compatible by adding it to the > > supported features and keeping the header length > > the same as for mergeable RX buffers. > >

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Andriy Berestovskyy
Hi guys, Just a minor note: ARM is bi-endian in fact. For instance, there are both endians tool chains available on Linaro. Andriy On Fri, Oct 16, 2015 at 8:20 AM, Michael S. Tsirkin wrote: > On Fri, Oct 16, 2015 at 10:24:38AM +0800, Yuanhan Liu wrote: >> On Thu, Oct 15, 2015 at 04:18:59PM

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-16 Thread Michael S. Tsirkin
On Fri, Oct 16, 2015 at 10:24:38AM +0800, Yuanhan Liu wrote: > On Thu, Oct 15, 2015 at 04:18:59PM +0300, Michael S. Tsirkin wrote: > > On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > > > Make vhost-user virtio 1.0 compatible by adding it to the > > > supported features and

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-15 Thread Michael S. Tsirkin
On Thu, Oct 15, 2015 at 02:08:39PM +0300, Marcel Apfelbaum wrote: > Make vhost-user virtio 1.0 compatible by adding it to the > supported features and keeping the header length > the same as for mergeable RX buffers. > > Signed-off-by: Marcel Apfelbaum Looks good to me Acked-by: Michael S.

[dpdk-dev] [PATCH] vhost-user: enable virtio 1.0

2015-10-15 Thread Marcel Apfelbaum
Make vhost-user virtio 1.0 compatible by adding it to the supported features and keeping the header length the same as for mergeable RX buffers. Signed-off-by: Marcel Apfelbaum --- To be applied on top of: [dpdk-dev] [PATCH v6 00/13] vhost-user multiple queues enabling Thanks, Marcel