Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Stephen Hemminger
On Wed, 23 Aug 2017 18:14:44 +0200 Olivier MATZ wrote: > On Wed, Aug 23, 2017 at 08:31:35AM -0700, Stephen Hemminger wrote: > > On Wed, 23 Aug 2017 11:30:26 +0200 > > Olivier MATZ wrote: > > > > > Hello, > > > > > > On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > > > > On Fr

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Olivier MATZ
On Wed, Aug 23, 2017 at 08:31:35AM -0700, Stephen Hemminger wrote: > On Wed, 23 Aug 2017 11:30:26 +0200 > Olivier MATZ wrote: > > > Hello, > > > > On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > > > On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > > > > While

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Stephen Hemminger
On Wed, 23 Aug 2017 11:30:26 +0200 Olivier MATZ wrote: > Hello, > > On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > > On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > > > While doing code for Hyper-V, noticed that the virtio driver was > > > confused about re

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-08-23 Thread Olivier MATZ
Hello, On Sat, Jul 08, 2017 at 11:12:22AM +0800, Yuanhan Liu wrote: > On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > > While doing code for Hyper-V, noticed that the virtio driver was > > confused about receive versus transmit offloads. The virtio > > checksum offload is L4

Re: [dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-07-07 Thread Yuanhan Liu
On Fri, Jul 07, 2017 at 12:52:48PM -0700, Stephen Hemminger wrote: > While doing code for Hyper-V, noticed that the virtio driver was > confused about receive versus transmit offloads. The virtio > checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO > and LRO are not the same. > > This may

[dpdk-dev] [PATCH 0/2] virtio fix false offload claims

2017-07-07 Thread Stephen Hemminger
While doing code for Hyper-V, noticed that the virtio driver was confused about receive versus transmit offloads. The virtio checksum offload is L4 (TCP/UDP) only, not IPv4. Also, TSO and LRO are not the same. This may break some program that was assuming it was getting offloads that it wasn't.