[dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-07-31 Thread Stephen Hemminger
Declaring variables as register in C is a leftover from an earlier era (like cassette tape decks in cars). Stephen Hemminger (5): qat: remove redundant C register keyword qede: remove register from declaraitons ark: remove register keyword mlx5: no need for register keyword mlx4: remove

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-10-09 Thread Ferruh Yigit
On 8/23/2018 2:07 PM, Ferruh Yigit wrote: > On 8/1/2018 10:03 PM, Stephen Hemminger wrote: >> On Wed, 1 Aug 2018 18:03:04 + >> Yongseok Koh wrote: >> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger wrote: On Tue, 31 Jul 2018 18:48:40 +0200 Adrien Mazarguil wrote: >>

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-07-31 Thread Adrien Mazarguil
On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote: > Declaring variables as register in C is a leftover from an earlier > era (like cassette tape decks in cars). I don't agree here. It's a hint for compilers and developers that the address of such variables won't be needed (and can

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-07-31 Thread Stephen Hemminger
On Tue, 31 Jul 2018 18:48:40 +0200 Adrien Mazarguil wrote: > On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote: > > Declaring variables as register in C is a leftover from an earlier > > era (like cassette tape decks in cars). > > I don't agree here. It's a hint for compilers a

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-08-01 Thread Matan Azrad
Hi Stephen Can you elaborate more? Can you add references? > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, July 31, 2018 7:31 PM > To: dev@dpdk.org > Cc: Stephen Hemminger > Subject: [dpdk-dev] [PATCH 0/

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-08-01 Thread Yongseok Koh
> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger > wrote: > > On Tue, 31 Jul 2018 18:48:40 +0200 > Adrien Mazarguil wrote: > >> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote: >>> Declaring variables as register in C is a leftover from an earlier >>> era (like cassette ta

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-08-01 Thread Stephen Hemminger
On Wed, 1 Aug 2018 18:03:04 + Yongseok Koh wrote: > > On Jul 31, 2018, at 11:07 AM, Stephen Hemminger > > wrote: > > > > On Tue, 31 Jul 2018 18:48:40 +0200 > > Adrien Mazarguil wrote: > > > >> On Tue, Jul 31, 2018 at 09:30:54AM -0700, Stephen Hemminger wrote: > >>> Declaring variable

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2018-08-23 Thread Ferruh Yigit
On 8/1/2018 10:03 PM, Stephen Hemminger wrote: > On Wed, 1 Aug 2018 18:03:04 + > Yongseok Koh wrote: > >>> On Jul 31, 2018, at 11:07 AM, Stephen Hemminger >>> wrote: >>> >>> On Tue, 31 Jul 2018 18:48:40 +0200 >>> Adrien Mazarguil wrote: >>> On Tue, Jul 31, 2018 at 09:30:54AM -0700,

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Tom Barbette
Hi all, Has there been any change regarding this? I'm still at DPDK 18.11. Maybe automatically add -Wno-register when C++17 is enabled? Or have a some register macro which gets undefined if C++17 is enabled? The "warning: ISO C++1z does not allow ‘register’ storage class specifier" is annoyi

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Bruce Richardson
On Thu, Jan 31, 2019 at 09:02:36AM +0100, Tom Barbette wrote: > Hi all, > > Has there been any change regarding this? I'm still at DPDK 18.11. Maybe > automatically add -Wno-register when C++17 is enabled? Or have a some > register macro which gets undefined if C++17 is enabled? > > The "warning:

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Tom Barbette
On 2019-01-31 10:11, Bruce Richardson wrote: What header is that? From what I see the patchset only makes changes to .c files rather than any .h files, so not sure it would help in your case. Yes you're right. There are other occurrences of register indeed. I got the warning from rte_common.h:

Re: [dpdk-dev] [PATCH 0/5] remove usage of register keyword in C

2019-01-31 Thread Wiles, Keith
I agree using register for todays compilers is unnecessary and can actually be wrong in some cases. The compilers can pick the correct registers better then we can normally and restricting the compiler makes no sense. Sent from my iPhone > On Jan 31, 2019, at 3:11 AM, Bruce Richardson > wrot