Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-26 Thread Thomas Monjalon
26/10/2020 17:49, Thomas Monjalon: > 26/10/2020 16:06, Andrew Rybchenko: > > On 10/26/20 8:20 AM, Thomas Monjalon wrote: > > [snip] > > > - sa = pkt->userdata; > > > + sa = RTE_MBUF_DYNFIELD(pkt, security_dynfield_offset, > > > + struc

Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-26 Thread Akhil Goyal
> On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon > wrote: > > diff --git a/lib/librte_security/rte_security_driver.h > b/lib/librte_security/rte_security_driver.h > > index 1b561f8528..ba9691b4a0 100644 > > --- a/lib/librte_security/rte_security_driver.h > > +++ b/lib/librte_security/rte_security

Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-26 Thread Thomas Monjalon
26/10/2020 16:06, Andrew Rybchenko: > On 10/26/20 8:20 AM, Thomas Monjalon wrote: > > --- a/drivers/net/ixgbe/ixgbe_ipsec.c > > +++ b/drivers/net/ixgbe/ixgbe_ipsec.c > > - (union ixgbe_crypto_tx_desc_md *)&m->udata64; > > + (union ixgbe_crypto_tx_desc_md *) > > +

Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-26 Thread Andrew Rybchenko
On 10/26/20 8:20 AM, Thomas Monjalon wrote: > The device-specific metadata was stored in the deprecated field udata64. > It is moved to a dynamic mbuf field in order to allow removal of udata64. > > Signed-off-by: Thomas Monjalon [snip] > diff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/n

Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-26 Thread Thomas Monjalon
26/10/2020 11:41, David Marchand: > On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon wrote: > > +/* Dynamic mbuf field for device-specific metadata */ > > +static const struct rte_mbuf_dynfield rte_security_dynfield_desc = { > > + .name = RTE_SECURITY_DYNFIELD_NAME, > > + .size = sizeof

Re: [dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-26 Thread David Marchand
On Mon, Oct 26, 2020 at 6:21 AM Thomas Monjalon wrote: > diff --git a/lib/librte_security/rte_security_driver.h > b/lib/librte_security/rte_security_driver.h > index 1b561f8528..ba9691b4a0 100644 > --- a/lib/librte_security/rte_security_driver.h > +++ b/lib/librte_security/rte_security_driver.h >

[dpdk-dev] [PATCH 05/15] security: switch metadata to dynamic mbuf field

2020-10-25 Thread Thomas Monjalon
The device-specific metadata was stored in the deprecated field udata64. It is moved to a dynamic mbuf field in order to allow removal of udata64. Signed-off-by: Thomas Monjalon --- doc/guides/prog_guide/rte_security.rst| 9 + drivers/crypto/octeontx2/otx2_cryptodev_sec.c | 5 +