[dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-11 Thread Jan Blunck
Let the rte_eal_devargs_parse() function parse the "bus=" argument. Signed-off-by: Jan Blunck --- lib/librte_eal/common/eal_common_devargs.c | 131 ++--- test/test/test_devargs.c | 19 + 2 files changed, 102 insertions(+), 48 deletions(-) diff --gi

Re: [dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-13 Thread Gaëtan Rivet
I still disagree with parsing the body of devargs to retrieve bus information. They should not be mixed. This conceptual discrepancy can be seen plainly in the code structure: you emulate librte_kvargs because you do not want to depend on it within the EAL, but copy its behavior and are forced to

Re: [dpdk-dev] [PATCH 09/13] devargs: parse "bus=" argument

2017-07-13 Thread Jan Blunck
On Thu, Jul 13, 2017 at 9:40 AM, Gaëtan Rivet wrote: > I still disagree with parsing the body of devargs to retrieve bus > information. They should not be mixed. > I agree. I always said that it should be passed explicitly. If we agree on this I'll fix the signature of rte_eal_devargs_parse() acc