[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-03-10 Thread Bruce Richardson
On Fri, Mar 04, 2016 at 10:28:44PM +, Rasesh Mody wrote: > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chas Williams > > Sent: Wednesday, December 30, 2015 4:38 PM > > > > From: "Charles (Chas) Williams" > > > > bnx2x_loop_obtain_resources() returns a struct containing the stat

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-03-04 Thread Rasesh Mody
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Chas Williams > Sent: Wednesday, December 30, 2015 4:38 PM > > From: "Charles (Chas) Williams" > > bnx2x_loop_obtain_resources() returns a struct containing the status and > the error message. If bnx2x_do_req4pf() fails, it shouldn't ret

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-02-08 Thread Bruce Richardson
On Mon, Feb 08, 2016 at 07:53:46AM -0800, Charles (Chas) Williams wrote: > I am afraid I don't understand what you are asking. This was broken in the > commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be > Perfect. Generally, when adding a patch which fixes something, we add in a "

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-02-08 Thread Bruce Richardson
On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: > From: "Charles (Chas) Williams" > > bnx2x_loop_obtain_resources() returns a struct containing the status and > the error message. If bnx2x_do_req4pf() fails, it shouldn't return both > of these fields set to 0 indicating failure an

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2016-02-08 Thread Charles (Chas) Williams
I am afraid I don't understand what you are asking. This was broken in the commit that added bnx2x, 540a211084a7695a1c7bc43068934c140d6989be On 02/08/2016 05:51 AM, Bruce Richardson wrote: > On Wed, Dec 30, 2015 at 07:37:50PM -0500, Chas Williams wrote: >> From: "Charles (Chas) Williams" >> >> b

[dpdk-dev] [PATCH 1/2] bnx2x: fix error handling in bnx2x_loop_obtain_resources()

2015-12-30 Thread Chas Williams
From: "Charles (Chas) Williams" bnx2x_loop_obtain_resources() returns a struct containing the status and the error message. If bnx2x_do_req4pf() fails, it shouldn't return both of these fields set to 0 indicating failure and no error. Further, bnx2x_do_req4pf() needs to be able fail and return