Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build

2018-10-18 Thread Burakov, Anatoly
On 16-Oct-18 1:38 PM, Ferruh Yigit wrote: On 10/16/2018 1:04 PM, Ferruh Yigit wrote: On 10/16/2018 12:41 PM, Jeff Guo wrote: When compiling on FreeBSD, a warning/error is thrown for unused parameter. This patch aim to fix the issue by delete the useless func definition. This function is part

Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 1:04 PM, Ferruh Yigit wrote: > On 10/16/2018 12:41 PM, Jeff Guo wrote: >> When compiling on FreeBSD, a warning/error is thrown for >> unused parameter. This patch aim to fix the issue by delete >> the useless func definition. > > This function is part of the public API, so it should

Re: [dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build

2018-10-16 Thread Ferruh Yigit
On 10/16/2018 12:41 PM, Jeff Guo wrote: > When compiling on FreeBSD, a warning/error is thrown for > unused parameter. This patch aim to fix the issue by delete > the useless func definition. This function is part of the public API, so it should exist for FreeBSD, I think instead of deleting the f

[dpdk-dev] [PATCH 1/2] eal/bsd: fix FreeBSD build

2018-10-16 Thread Jeff Guo
When compiling on FreeBSD, a warning/error is thrown for unused parameter. This patch aim to fix the issue by delete the useless func definition. Signed-off-by: Jeff Guo --- lib/librte_eal/bsdapp/eal/eal_dev.c | 8 1 file changed, 8 deletions(-) diff --git a/lib/librte_eal/bsdapp/eal/e