Re: [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header

2018-05-02 Thread Stephen Hemminger
On Wed, 2 May 2018 10:40:08 +0100 Ferruh Yigit wrote: > On 5/1/2018 7:56 PM, Thomas Monjalon wrote: > > 01/05/2018 19:28, Ferruh Yigit: > >> --- a/lib/librte_ethdev/rte_ethdev.c > >> +++ b/lib/librte_ethdev/rte_ethdev.c > >> -static int ethdev_logtype; > >> - > >> -#define ethdev_log(level, fmt

Re: [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header

2018-05-02 Thread Ferruh Yigit
On 5/1/2018 7:56 PM, Thomas Monjalon wrote: > 01/05/2018 19:28, Ferruh Yigit: >> --- a/lib/librte_ethdev/rte_ethdev.c >> +++ b/lib/librte_ethdev/rte_ethdev.c >> -static int ethdev_logtype; >> - >> -#define ethdev_log(level, fmt, ...) \ >> -rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ##

Re: [dpdk-dev] [PATCH 1/2] ethdev: move log macro to header

2018-05-01 Thread Thomas Monjalon
01/05/2018 19:28, Ferruh Yigit: > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > -static int ethdev_logtype; > - > -#define ethdev_log(level, fmt, ...) \ > - rte_log(RTE_LOG_ ## level, ethdev_logtype, fmt "\n", ## __VA_ARGS__) > +int ethdev_logtype; > [...] > --

[dpdk-dev] [PATCH 1/2] ethdev: move log macro to header

2018-05-01 Thread Ferruh Yigit
Signed-off-by: Ferruh Yigit --- lib/librte_ethdev/rte_ethdev.c | 17 +++-- lib/librte_ethdev/rte_ethdev.h | 5 + 2 files changed, 12 insertions(+), 10 deletions(-) diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c index 5a67e6a7d..a1fbb081d 100644 ---