[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-06 Thread Thomas Monjalon
2015-07-06 10:20, Bruce Richardson: > On Fri, Jul 03, 2015 at 09:57:26PM +0200, Thomas Monjalon wrote: > > 2015-07-03 16:56, Bruce Richardson: > > > On Fri, Jul 03, 2015 at 05:45:34PM +0200, Thomas Monjalon wrote: > > > > Hi Bruce, > > > > > > > > 2015-07-03 16:40, Bruce Richardson: > > > > > As w

[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-06 Thread Bruce Richardson
On Fri, Jul 03, 2015 at 09:57:26PM +0200, Thomas Monjalon wrote: > 2015-07-03 16:56, Bruce Richardson: > > On Fri, Jul 03, 2015 at 05:45:34PM +0200, Thomas Monjalon wrote: > > > Hi Bruce, > > > > > > 2015-07-03 16:40, Bruce Richardson: > > > > As well as the fast-path functions in the rxtx code, t

[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-03 Thread Thomas Monjalon
2015-07-03 16:56, Bruce Richardson: > On Fri, Jul 03, 2015 at 05:45:34PM +0200, Thomas Monjalon wrote: > > Hi Bruce, > > > > 2015-07-03 16:40, Bruce Richardson: > > > As well as the fast-path functions in the rxtx code, there are also > > > functions which set up and tear down the descriptor rings

[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-03 Thread Thomas Monjalon
Hi Bruce, 2015-07-03 16:40, Bruce Richardson: > As well as the fast-path functions in the rxtx code, there are also > functions which set up and tear down the descriptor rings. Since these > are not performance critical functions, there is no need to have them > extensively optimized, so we add __

[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-03 Thread Bruce Richardson
On Fri, Jul 03, 2015 at 05:45:34PM +0200, Thomas Monjalon wrote: > Hi Bruce, > > 2015-07-03 16:40, Bruce Richardson: > > As well as the fast-path functions in the rxtx code, there are also > > functions which set up and tear down the descriptor rings. Since these > > are not performance critical f

[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-03 Thread Bruce Richardson
As well as the fast-path functions in the rxtx code, there are also functions which set up and tear down the descriptor rings. Since these are not performance critical functions, there is no need to have them extensively optimized, so we add __attribute__((cold)) to their definitions. This has the

[dpdk-dev] [PATCH 1/2] ixgbe: add "cold" attribute to setup/teardown fns

2015-07-03 Thread Stephen Hemminger
On Fri, 3 Jul 2015 16:40:05 +0100 Bruce Richardson wrote: > --- a/drivers/net/ixgbe/ixgbe_rxtx.c > +++ b/drivers/net/ixgbe/ixgbe_rxtx.c > @@ -1757,7 +1757,7 @@ ixgbe_recv_pkts_lro_bulk_alloc(void *rx_queue, struct > rte_mbuf **rx_pkts, > * needed. If the memzone is already created, then this