[dpdk-dev] [PATCH 1/2] ixgbe: remove static qualifier for thread safety

2014-10-24 Thread Masaru Oki
Oh, sorry, you are right. I had missed first * for copy. thank you. 2014-10-24 19:34 GMT+09:00 Bruce Richardson : > On Thu, Oct 23, 2014 at 08:43:39AM +0900, Masaru Oki wrote: >> Hi, >> >> in this code, pointer of local variable (mb_def) is returned by your changes. >> mb_def should be static

[dpdk-dev] [PATCH 1/2] ixgbe: remove static qualifier for thread safety

2014-10-24 Thread Bruce Richardson
On Thu, Oct 23, 2014 at 08:43:39AM +0900, Masaru Oki wrote: > Hi, > > in this code, pointer of local variable (mb_def) is returned by your changes. > mb_def should be static for each thread. Actually, no. A copy is made of 8 bytes of the mb_def variable and stored as an mbuf initializer inside

[dpdk-dev] [PATCH 1/2] ixgbe: remove static qualifier for thread safety

2014-10-23 Thread Masaru Oki
Hi, in this code, pointer of local variable (mb_def) is returned by your changes. mb_def should be static for each thread. 2014-10-22 19:55 GMT+09:00 Bruce Richardson : > Remove the "static" prefix to the template mbuf variable in > ixgbe_rxq_vec_setup function. This will then allow different >

[dpdk-dev] [PATCH 1/2] ixgbe: remove static qualifier for thread safety

2014-10-22 Thread Bruce Richardson
Remove the "static" prefix to the template mbuf variable in ixgbe_rxq_vec_setup function. This will then allow different threads to initialize different RX queues at the same time, without one overwriting the other's data. Signed-off-by: Bruce Richardson ---