Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2018-01-10 Thread Hemant Agrawal
Hi Olivier, I just feel it's a bit messy to have: - rte_eal_mbuf_default_mempool_ops() in eal API return user-selected ops if any, or compile-time default - rte_pktmbuf_active_mempool_ops() in mbuf API return platform ops except if a selected user ops != compile default Thomas suggested s

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-28 Thread Hemant Agrawal
...@caviumnetworks.com CC: dev@dpdk.org Subject: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool X-Mailer: git-send-email 2.7.4 With this patch the specific HW mempool are no longer required to be specified in the config file at compile. A default active hw mempool can be

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-22 Thread Olivier MATZ
...@caviumnetworks.com > > > CC: dev@dpdk.org > > > Subject: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW > > > active pool > > > X-Mailer: git-send-email 2.7.4 > > > > > > With this patch the specific HW mempool are no longer

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-22 Thread Olivier MATZ
Hi, On Fri, Dec 15, 2017 at 03:54:42PM +0530, Hemant Agrawal wrote: > With this patch the specific HW mempool are no longer required to be > specified in the config file at compile. A default active hw mempool > can be detected dynamically and published to default mempools ops > config at run time

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-18 Thread Hemant Agrawal
On 12/18/2017 2:25 PM, Jerin Jacob wrote: -Original Message- Date: Fri, 15 Dec 2017 15:54:42 +0530 From: Hemant Agrawal To: olivier.m...@6wind.com, santosh.shu...@caviumnetworks.com CC: dev@dpdk.org Subject: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool X

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-18 Thread Hemant Agrawal
On 12/15/2017 9:22 PM, Stephen Hemminger wrote: On Fri, 15 Dec 2017 15:54:42 +0530 Hemant Agrawal wrote: + if ((strcmp(default_ops, RTE_MBUF_DEFAULT_MEMPOOL_OPS) == 0) && + (active_mbuf_pool_ops_name != NULL)) Why not have less parenthesis () in conditionals? I will cha

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-18 Thread Jerin Jacob
-Original Message- > Date: Fri, 15 Dec 2017 15:54:42 +0530 > From: Hemant Agrawal > To: olivier.m...@6wind.com, santosh.shu...@caviumnetworks.com > CC: dev@dpdk.org > Subject: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW > active pool > X-Mailer:

Re: [dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-15 Thread Stephen Hemminger
On Fri, 15 Dec 2017 15:54:42 +0530 Hemant Agrawal wrote: > + if ((strcmp(default_ops, RTE_MBUF_DEFAULT_MEMPOOL_OPS) == 0) && > + (active_mbuf_pool_ops_name != NULL)) Why not have less parenthesis () in conditionals?

[dpdk-dev] [PATCH 1/2] mbuf: update default Mempool ops with HW active pool

2017-12-15 Thread Hemant Agrawal
With this patch the specific HW mempool are no longer required to be specified in the config file at compile. A default active hw mempool can be detected dynamically and published to default mempools ops config at run time. Only one type of HW mempool can be active default. Signed-off-by: Hemant A