Re: [dpdk-dev] [PATCH 1/2] net/pcap: multiple queues fix

See Inline prefixed with [ido] -Original Message- From: Ferruh Yigit Sent: Monday, June 18, 2018 11:25 AM To: Ido Goshen Cc: dev@dpdk.org Subject: Re: [PATCH 1/2] net/pcap: multiple queues fix On 6/16/2018 4:36 PM, ido goshen wrote: > Change open_rx/tx_pcap/iface functions to open only

Re: [dpdk-dev] [PATCH 1/2] net/pcap: multiple queues fix

On 6/19/2018 10:45 AM, Ido Goshen wrote: > See Inline prefixed with [ido] > > -Original Message- > From: Ferruh Yigit > Sent: Monday, June 18, 2018 11:25 AM > To: Ido Goshen > Cc: dev@dpdk.org > Subject: Re: [PATCH 1/2] net/pcap: multiple queues fix > > On 6/16/2018 4:36 PM, ido goshen

Re: [dpdk-dev] [PATCH 1/2] net/pcap: multiple queues fix

On 6/16/2018 4:36 PM, ido goshen wrote: > Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper > and not loop num_of_queue times > The num_of_queue loop is already acheived by the caller rte_kvargs_process You are right, thanks for fixing this, a few comments below. > > Fixes

[dpdk-dev] [PATCH 1/2] net/pcap: multiple queues fix

Change open_rx/tx_pcap/iface functions to open only a single pcap/dumper and not loop num_of_queue times The num_of_queue loop is already acheived by the caller rte_kvargs_process Fixes: 1. Opens N requested pcaps/dumpers instead of N^2 2. Leak of pcap/dumper's which are being overwritten by th