[dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-03 Thread Matan Azrad
Missed 4 spaces were added after break if line. Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") Signed-off-by: Matan Azrad --- drivers/net/tap/tap_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-03 Thread Matan Azrad
I sent it from root user by mistake, sorry! I Sent it again with my user. > -Original Message- > From: root [mailto:r...@pegasus12.mtr.labs.mlnx] > Sent: Tuesday, October 3, 2017 5:52 PM > To: Pascal Mazon > Cc: dev@dpdk.org; Matan Azrad > Subject: [PATCH 1/2] net/tap: fix indentation in

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-03 Thread Ferruh Yigit
On 10/3/2017 3:55 PM, Matan Azrad wrote: > Missed 4 spaces were added after break if line. > > Fixes: 7a6811d78ed6 ("net/tap: fix flow and port commands") What do you think fixing this when that code has been touched next time? > > Signed-off-by: Matan Azrad > --- > drivers/net/tap/tap_flow.c

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-04 Thread Pascal Mazon
Hi, I'm surprised there's only one place in the file with indent problem, but I'm ok with the patch otherwise. Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in patch 2/2, right? Best regards, Pascal On 04/10/2017 00:07, Ferruh Yigit wrote: > On 10/3/2017 3:55 PM, Matan Azrad

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-04 Thread Ferruh Yigit
On 10/4/2017 9:15 AM, Pascal Mazon wrote: > Hi, > > I'm surprised there's only one place in the file with indent problem, > but I'm ok with the patch otherwise. > > Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in > patch 2/2, right? I wasn't sure about getting the patch that

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-05 Thread Ferruh Yigit
On 10/4/2017 6:26 PM, Ferruh Yigit wrote: > On 10/4/2017 9:15 AM, Pascal Mazon wrote: >> Hi, >> >> I'm surprised there's only one place in the file with indent problem, >> but I'm ok with the patch otherwise. >> >> Ferruh, I didn't get what you mean; Matan is modifying tap_flow.c in >> patch 2/2, r

Re: [dpdk-dev] [PATCH 1/2] net/tap: fix indentation in flow file

2017-10-16 Thread Pascal Mazon
Hi, Sorry for the delay, I was on vacation. Nevermind this indent patch for now. Matan, could you integrate it (squashed) when you'll have a new patch modifying tap_flow.c? Thank you. Regards, Pascal On 05/10/2017 23:33, Ferruh Yigit wrote: > On 10/4/2017 6:26 PM, Ferruh Yigit wrote: >> On 10/