Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Tyler Retzlaff
On Thu, Mar 18, 2021 at 02:48:01PM +, Tal Shnaiderman wrote: > > I don't know if this table is needed, the approach should be to have the > return value/rte_errno identical between the OSs. > And having the specific OS errno printed. the underlying problem here is that dpdk is adopting linux

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Narcisa Ana Maria Vasile
On Thu, Mar 18, 2021 at 02:48:01PM +, Tal Shnaiderman wrote: > > Subject: [dpdk-dev] [PATCH 1/3] Add EAL threads API > > > > From: Narcisa Vasile > > > > EAL must hide the environment specifics from apps and libraries. > > Add an EAL API for managing thre

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Narcisa Ana Maria Vasile
On Thu, Mar 18, 2021 at 04:48:49PM +0100, David Marchand wrote: > On Thu, Mar 18, 2021 at 2:01 AM Narcisa Ana Maria Vasile > wrote: > > diff --git a/lib/librte_eal/common/eal_common_thread.c > > b/lib/librte_eal/common/eal_common_thread.c > > index 73a055902..5219e783e 100644 > > --- a/lib/librte

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread David Marchand
On Thu, Mar 18, 2021 at 2:01 AM Narcisa Ana Maria Vasile wrote: > diff --git a/lib/librte_eal/common/eal_common_thread.c > b/lib/librte_eal/common/eal_common_thread.c > index 73a055902..5219e783e 100644 > --- a/lib/librte_eal/common/eal_common_thread.c > +++ b/lib/librte_eal/common/eal_common_thr

Re: [dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-18 Thread Tal Shnaiderman
> Subject: [dpdk-dev] [PATCH 1/3] Add EAL threads API > > From: Narcisa Vasile > > EAL must hide the environment specifics from apps and libraries. > Add an EAL API for managing threads. > > Signed-off-by: Narcisa Vasile > Signed-off-by: Dmitry Malloy > --- Hi

[dpdk-dev] [PATCH 1/3] Add EAL threads API

2021-03-17 Thread Narcisa Ana Maria Vasile
From: Narcisa Vasile EAL must hide the environment specifics from apps and libraries. Add an EAL API for managing threads. Signed-off-by: Narcisa Vasile Signed-off-by: Dmitry Malloy --- lib/librte_eal/common/eal_common_thread.c | 6 +- lib/librte_eal/common/rte_thread.c| 346