On Sat, Oct 08, 2016 at 12:47:59PM +, Shreyansh Jain wrote:
>
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Sent: Friday, October 07, 2016 7:15 PM
> > To: Shreyansh Jain
> > Cc: david.marchand at 6wind.com; dev at dpdk.org
> > Subject: R
On Tuesday 11 October 2016 08:27 PM, Neil Horman wrote:
> On Tue, Oct 11, 2016 at 03:57:29PM +0200, Thomas Monjalon wrote:
>> 2016-10-11 09:38, Neil Horman:
>>> This also begs the question in my mind, is it really worth changing the
>>> macro?
>>> I really don't think it is. The registration macr
2016-10-11 09:38, Neil Horman:
> This also begs the question in my mind, is it really worth changing the macro?
> I really don't think it is. The registration macros are pretty descriptive as
> they stand, and have already changed 3 or 4 times in the last 6 months, which
> suggests to me that any
On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
>> Hi Thomas,
>>
>>> -Original Message-
>>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
>>> Sent: Friday, October 07, 2016 7:22 PM
>>> To: Shreyansh Jain
On Tue, Oct 11, 2016 at 03:57:29PM +0200, Thomas Monjalon wrote:
> 2016-10-11 09:38, Neil Horman:
> > This also begs the question in my mind, is it really worth changing the
> > macro?
> > I really don't think it is. The registration macros are pretty descriptive
> > as
> > they stand, and have
On Tue, Oct 11, 2016 at 12:06:27PM +0530, Shreyansh Jain wrote:
> On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> > On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
> > > Hi Thomas,
> > >
> > > > -Original Message-
> > > > From: Thomas Monjalon [mailto:thomas.monjal
2016-10-11 12:06, Shreyansh Jain:
> On Monday 10 October 2016 06:26 PM, Neil Horman wrote:
> > On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
> >> Hi Thomas,
> >>
> >>> -Original Message-
> >>> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> >>> Sent: Friday,
On Sat, Oct 08, 2016 at 01:00:59PM +, Shreyansh Jain wrote:
> Hi Thomas,
>
> > -Original Message-
> > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> > Sent: Friday, October 07, 2016 7:22 PM
> > To: Shreyansh Jain
> > Cc: david.marchand at 6wind.com; dev at dpdk.org
> >
Hi Neil,
> -Original Message-
> From: Neil Horman [mailto:nhorman at tuxdriver.com]
> Sent: Friday, October 07, 2016 7:48 PM
> To: Thomas Monjalon
> Cc: Shreyansh Jain ; david.marchand at 6wind.com;
> dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH 1/3] eal/d
Hi Thomas,
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, October 07, 2016 7:22 PM
> To: Shreyansh Jain
> Cc: david.marchand at 6wind.com; dev at dpdk.org
> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
>
> -Original Message-
> From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com]
> Sent: Friday, October 07, 2016 7:15 PM
> To: Shreyansh Jain
> Cc: david.marchand at 6wind.com; dev at dpdk.org
> Subject: Re: [PATCH 1/3] eal/drivers: prefix driver REGISTER macros with EAL
>
> 2016-10-
Hi David, Thomas,
On Friday 07 October 2016 07:03 PM, Shreyansh Jain wrote:
> DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
>
> Signed-off-by: Shreyansh Jain
> ---
> doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-
> drivers/crypto/qat/rte_qa
DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
Signed-off-by: Shreyansh Jain
---
doc/guides/prog_guide/dev_kit_build_system.rst | 2 +-
drivers/crypto/qat/rte_qat_cryptodev.c | 4 ++--
drivers/net/bnx2x/bnx2x_ethdev.c | 8 ---
2016-10-07 19:11, Shreyansh Jain:
> --- a/mk/internal/rte.compile-pre.mk
> +++ b/mk/internal/rte.compile-pre.mk
> @@ -87,7 +87,7 @@ endif
> PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c
> PMDINFO_CC = $(CC) $(CPPFLAGS) $(CFLAGS) -c -o $@.pmd.o $@.pmd.c
> PMDINFO_LD = $(CROSS)ld
2016-10-07 19:03, Shreyansh Jain:
> DRIVER_REGISTER_PCI -> EAL_REGISTER_PCI
> DRIVER_REGISTER_PCI_TABLE -> EAL_REGISTER_PCI_TABLE
Why not RTE_ prefix instead of EAL_?
Why 3 patches? As there is no specific comment in each, I think you can squash.
On Fri, Oct 07, 2016 at 03:51:44PM +0200, Thomas Monjalon wrote:
> 2016-10-07 19:11, Shreyansh Jain:
> > --- a/mk/internal/rte.compile-pre.mk
> > +++ b/mk/internal/rte.compile-pre.mk
> > @@ -87,7 +87,7 @@ endif
> > PMDINFO_GEN = $(RTE_SDK_BIN)/app/dpdk-pmdinfogen $@ $@.pmd.c
> > PMDINFO_CC = $(
16 matches
Mail list logo
