[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-12-01 Thread Ananyev, Konstantin
Hi lads, > -Original Message- > From: Liu, Jijiang > Sent: Monday, December 01, 2014 1:08 PM > To: Olivier MATZ; Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change > three fields > > &

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-12-01 Thread Olivier MATZ
Hi Konstantin, On 12/01/2014 12:58 PM, Ananyev, Konstantin wrote: >> Ether/IP/UDP/vxlan/Ether/IP/UDP/xxx >> m->outer_l2_len = sizeof(ether) >> m->outer_l3_len = sizeof(ip) >> m->l2_len = sizeof(udp) + sizeof(vxlan) + sizeof(ether) > > I think it should be: > m->l2_len = sizeof(vxlan) + size

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-12-01 Thread Liu, Jijiang
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, December 1, 2014 8:28 PM > To: Ananyev, Konstantin; Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change >

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-12-01 Thread Ananyev, Konstantin
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Monday, December 01, 2014 9:52 AM > To: Liu, Jijiang; Ananyev, Konstantin > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change >

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-12-01 Thread Olivier MATZ
Hi Jijiang, On 12/01/2014 03:30 AM, Liu, Jijiang wrote: >> After another thought, I think that the way you proposed is a better one. >> I gives us more flexibility: >> let's say for now we'll keep both l2_len and outer_l2_len as 7 bit fields, >> and upper >> layer would have to: >> mb->l2_len =

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-12-01 Thread Liu, Jijiang
> -Original Message- > From: Ananyev, Konstantin > Sent: Sunday, November 30, 2014 10:51 PM > To: Olivier MATZ; Liu, Jijiang > Cc: dev at dpdk.org > Subject: RE: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change > three fields > > Hi Olver, &

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-30 Thread Ananyev, Konstantin
Hi Olver, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 28, 2014 10:46 AM > To: Ananyev, Konstantin; Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and chan

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-28 Thread Olivier MATZ
Hi Konstantin, On 11/27/2014 06:01 PM, Ananyev, Konstantin wrote: >> Yes, I think it could be done that way too. >> Though I still prefer to keep l4tun_len - it makes things a bit cleaner (at >> least to me). >> After all we do have space for it in mbuf's tx_offload. > > As one more thing in fa

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-28 Thread Ananyev, Konstantin
Hi Olver, > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Friday, November 28, 2014 10:46 AM > To: Ananyev, Konstantin; Liu, Jijiang > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and chan

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-28 Thread Olivier MATZ
Hi Jijiang, On 11/27/2014 02:14 PM, Liu, Jijiang wrote: >>> diff --git a/lib/librte_mbuf/rte_mbuf.h b/lib/librte_mbuf/rte_mbuf.h >>> index 367fc56..48cd8e1 100644 >>> --- a/lib/librte_mbuf/rte_mbuf.h >>> +++ b/lib/librte_mbuf/rte_mbuf.h >>> @@ -99,10 +99,9 @@ extern "C" { >>> #define PKT_RX_TUN

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-27 Thread Ananyev, Konstantin
add two TX offload flags and change > three fields > > > > > > > -Original Message- > > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > > Sent: Thursday, November 27, 2014 6:00 PM > > To: Liu, Jijiang; dev at dpdk.org > > Sub

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-27 Thread Jijiang Liu
In place of removing the PKT_TX_VXLAN_CKSUM, we introduce 2 new flags: PKT_TX_OUT_IP_CKSUM, PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len. Replace the inner_l2_len and the inner_l3_len field with the outer_l2_len and outer_l3_len field. PKT_TX_OUT_IP_CKSUM: is not used for non-tunnelling pa

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-27 Thread Ananyev, Konstantin
> > -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Thursday, November 27, 2014 6:00 PM > To: Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change > three fields > >

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-27 Thread Liu, Jijiang
> -Original Message- > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > Sent: Thursday, November 27, 2014 6:00 PM > To: Liu, Jijiang; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change > three fields > > Hi Jijia

[dpdk-dev] [PATCH 1/3] mbuf:add two TX offload flags and change three fields

2014-11-27 Thread Olivier MATZ
Hi Jijiang, Please see some comments below. On 11/27/2014 09:18 AM, Jijiang Liu wrote: > In place of removing the PKT_TX_VXLAN_CKSUM, we introduce 2 new flags: > PKT_TX_OUT_IP_CKSUM, PKT_TX_UDP_TUNNEL_PKT, and a new field: l4_tun_len. > Replace the inner_l2_len and the inner_l3_len field with th