[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-27 Thread Thomas Monjalon
2014-06-26 13:20, Aaron Campbell: > On Jun 26, 2014, at 12:09 PM, Richardson, Bruce intel.com> wrote: > >> I agree we should try to use the "deprecated" attribute when possible. > >> So application porting effort will be smoother. > >> > >> But in this case, there is something different: as Step

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-26 Thread Richardson, Bruce
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 25, 2014 1:33 AM > To: Richardson, Bruce > Cc: dev at dpdk.org; Stephen Hemminger > Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf >

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-26 Thread Aaron Campbell
On Jun 26, 2014, at 12:09 PM, Richardson, Bruce wrote: >> I agree we should try to use the "deprecated" attribute when possible. >> So application porting effort will be smoother. >> >> But in this case, there is something different: as Stephen wrote, >> rte_snprintf >> is useless. It's useles

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-25 Thread Thomas Monjalon
2014-06-24 17:39, Richardson, Bruce: > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > > The function rte_snprintf serves no useful purpose. It is the > > same as snprintf() for all valid inputs. Just remove it and > > replace all uses in current code. > > NAK to this a

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-25 Thread Olivier MATZ
Hi Bruce, On 06/24/2014 08:00 PM, Richardson, Bruce wrote: >> I want to get it out now rather than some 2 year life cycle. >> The issue was discussed and marking it as deprecated breaks the build. >> Alternate is removing all instances and adding: >> >> #define rte_snprintf snprintf >> >> in heade

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-24 Thread Richardson, Bruce
> -Original Message- > From: Stephen Hemminger [mailto:stephen at networkplumber.org] > Sent: Tuesday, June 24, 2014 10:54 AM > To: Richardson, Bruce > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf > > On Tue, 24

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-24 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > Sent: Tuesday, June 24, 2014 9:03 AM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf > > The function rte_snprintf serves no usef

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-24 Thread Stephen Hemminger
On Tue, 24 Jun 2014 17:39:52 + "Richardson, Bruce" wrote: > > -Original Message- > > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Stephen Hemminger > > Sent: Tuesday, June 24, 2014 9:03 AM > > To: dev at dpdk.org > > Subject:

[dpdk-dev] [PATCH 1/3] stringfns: remove rte_snprintf

2014-06-24 Thread Stephen Hemminger
The function rte_snprintf serves no useful purpose. It is the same as snprintf() for all valid inputs. Just remove it and replace all uses in current code. Signed-off-by: Stephen Hemminger --- a/app/test-pipeline/init.c 2014-06-20 13:23:17.462947732 -0700 +++ b/app/test-pipeline/init.c 2014-0