Re: [dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation"

2020-11-12 Thread Maxime Leroy
Hi Slava, On Wed, Nov 11, 2020 at 8:51 PM Slava Ovsiienko wrote: > > Hi, Maxime > > Thanks a lot for the patch. There is the comment for the entire series. > > [1]_ > > > > First issue, when there are more than 8 CQEs to uncompress, the computation > > done in this commit cannot work. Because

Re: [dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation"

2020-11-11 Thread Slava Ovsiienko
Hi, Maxime Thanks a lot for the patch. There is the comment for the entire series. [1]_ > > First issue, when there are more than 8 CQEs to uncompress, the computation > done in this commit cannot work. Because the zip-ai variable describes the > current index inside the CQE8 array and thus

[dpdk-dev] [PATCH 1/4] Revert "net/mlx5: fix Rx queue count calculation"

2020-11-10 Thread Maxime Leroy
This reverts commit d2d57605522d4a43be17e22e649e54033f6d8835. This fix is uncorrect for at least two reasons. First issue, when there are more than 8 CQEs to uncompress, the computation done in this commit cannot work. Because the zip-ai variable describes the current index inside the CQE8 array