Hi Olivier,
On 3/4/2016 9:05 AM, Olivier MATZ wrote:
> Hi David,
>
@@ -622,6 +607,10 @@ rte_mempool_xmem_create(const char *name,
unsigned n, unsigned elt_size,
mp->elt_va_end = mp->elt_va_start;
+/* Parameters are setup. Call the mempool handler alloc */
Hi David,
>>
>>> @@ -622,6 +607,10 @@ rte_mempool_xmem_create(const char *name,
>>> unsigned n, unsigned elt_size,
>>>
>>> mp->elt_va_end = mp->elt_va_start;
>>>
>>> +/* Parameters are setup. Call the mempool handler alloc */
>>> +if ((rte_mempool_ext_alloc(mp, name, n, socket_id,
Olivier,
Here's my comments on your feedback. Hopefully I've covered all of
it this time, and I've summarised the outstanding questions at the bottom.
On 2/4/2016 2:52 PM, Olivier MATZ wrote:
>
>> -#ifndef RTE_LIBRTE_XEN_DOM0
>> -/* stub if DOM0 support not configured */
>> -struct
Hi David,
On 02/04/2016 05:47 PM, Hunt, David wrote:
> Olivier,
> Thanks for your comprehensive comments. I'm working on a v2 patch
> based on feedback already received from Jerin, and I'll be sure to
> include your feedback also.
> Many thanks,
> David.
While answering to Keith, I realized
Hi David,
On 02/04/2016 06:34 PM, Hunt, David wrote:
> On 04/02/2016 14:52, Olivier MATZ wrote:
>> Hi David,
>
> [snip]
>
> Just a comment on one of your comments:
>
>> Why not using a similar mechanism than what we have for PMDs?
>>
>> void rte_eal_driver_register(struct rte_driver
On Wed, Feb 03, 2016 at 02:16:06PM +, Hunt, David wrote:
> On 28/01/2016 17:52, Jerin Jacob wrote:
> >On Tue, Jan 26, 2016 at 05:25:51PM +, David Hunt wrote:
> >>Adds the new rte_mempool_create_ext api and callback mechanism for
> >>external mempool handlers
> >>
> >>Modifies the existing
On 04/02/2016 14:52, Olivier MATZ wrote:
> Hi David,
[snip]
Just a comment on one of your comments:
> Why not using a similar mechanism than what we have for PMDs?
>
> void rte_eal_driver_register(struct rte_driver *driver)
> {
> TAILQ_INSERT_TAIL(_driver_list, driver, next);
On 04/02/2016 14:52, Olivier MATZ wrote:
> Hi David,
>
> Nice work, thanks !
> Please see some comments below.
>
>
[snip]
Olivier,
Thanks for your comprehensive comments. I'm working on a v2 patch
based on feedback already received from Jerin, and I'll be sure to
include your feedback
On Tue, Jan 26, 2016 at 05:25:51PM +, David Hunt wrote:
> Adds the new rte_mempool_create_ext api and callback mechanism for
> external mempool handlers
>
> Modifies the existing rte_mempool_create to set up the handler_idx to
> the relevant mempool handler based on the handler name:
>
Adds the new rte_mempool_create_ext api and callback mechanism for
external mempool handlers
Modifies the existing rte_mempool_create to set up the handler_idx to
the relevant mempool handler based on the handler name:
ring_sp_sc
ring_mp_mc
ring_sp_mc
ring_mp_sc
10 matches
Mail list logo
