2014-10-29 17:57, Yong Wang:
> Sounds good to me but it does look like the rte_rxmbuf_alloc() could use
> some comments to make it explicit that rte_pktmbuf_reset() is avoided by
> design for the reasons that Bruce described. Furthermore,
> rte_rxmbuf_alloc() is duplicated in almost all the pmd
Sounds good to me but it does look like the rte_rxmbuf_alloc() could use
some comments to make it explicit that rte_pktmbuf_reset() is avoided by
design for the reasons that Bruce described. Furthermore,
rte_rxmbuf_alloc() is duplicated in almost all the pmd drivers. Will it
make sense to
2014-10-29 09:04, Bruce Richardson:
> On Tue, Oct 28, 2014 at 09:57:14PM +, Yong Wang wrote:
> > On 10/22/14, 6:39 AM, "Stephen Hemminger"
> > wrote:
> >
> >
> > >On Mon, 13 Oct 2014 18:42:18 +
> > >Yong Wang wrote:
> > >
> > >> Are you referring to the patch as a whole or your comment
On Tue, Oct 28, 2014 at 09:57:14PM +, Yong Wang wrote:
> On 10/22/14, 6:39 AM, "Stephen Hemminger"
> wrote:
>
>
> >On Mon, 13 Oct 2014 18:42:18 +
> >Yong Wang wrote:
> >
> >> Are you referring to the patch as a whole or your comment is about the
> >>reset of vlan_tci on the "else" (no
On 10/22/14, 6:39 AM, "Stephen Hemminger"
wrote:
>On Mon, 13 Oct 2014 18:42:18 +
>Yong Wang wrote:
>
>> Are you referring to the patch as a whole or your comment is about the
>>reset of vlan_tci on the "else" (no vlan tags stripped) path? I am not
>>sure I get your comments here. This
On Mon, 13 Oct 2014 18:42:18 +
Yong Wang wrote:
> Are you referring to the patch as a whole or your comment is about the reset
> of vlan_tci on the "else" (no vlan tags stripped) path? I am not sure I get
> your comments here. This patch simply fixes a bug on the rx vlan stripping
>
gt;
Sent: Monday, October 13, 2014 2:31 AM
To: Yong Wang
Cc: dev at dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/5] vmxnet3: Fix VLAN Rx stripping
On Sun, 12 Oct 2014 23:23:05 -0700
Yong Wang wrote:
> Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.
>
> Signed-off-by: Y
On Sun, 12 Oct 2014 23:23:05 -0700
Yong Wang wrote:
> Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.
>
> Signed-off-by: Yong Wang
Since vlan_tci is initialized to zero by rte_pktmbuf layer,
the driver shouldn't be messing with it.
Shouldn't reset vlan_tci to 0 if a valid VLAN tag is stripped.
Signed-off-by: Yong Wang
---
lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
b/lib/librte_pmd_vmxnet3/vmxnet3_rxtx.c
index
9 matches
Mail list logo
