Re: [dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-02 Thread Olivier Matz
On Thu, 2 Mar 2017 18:05:52 +0300, Andrew Rybchenko wrote: > On 03/02/2017 05:54 PM, Olivier Matz wrote: > > + * > > + * @param port_id > > + * The port identifier of the Ethernet device. > > + * @param queue_id > > + * The Rx queue identifier on this port. > > + * @para

Re: [dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-02 Thread Andrew Rybchenko
On 03/02/2017 05:54 PM, Olivier Matz wrote: + * + * @param port_id + * The port identifier of the Ethernet device. + * @param queue_id + * The Rx queue identifier on this port. + * @param offset + * The offset of the descriptor starting from tail (0 is the next + * packet to be received by th

Re: [dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-02 Thread Olivier Matz
> >>> + * Check the status of a Rx descriptor in the queue > >> I think it would be useful to highlight caller context. > >> Should it be the same CPU which receives packets from the queue? > > Yes, you are right it would be useful. I suggest the following sentences: > > > >This function s

Re: [dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-02 Thread Andrew Rybchenko
Hi Olivier, On 03/02/2017 04:57 PM, Olivier Matz wrote: Hi Andrew, Thank you for the review. Comments inline. On Wed, 1 Mar 2017 21:22:14 +0300, Andrew Rybchenko wrote: On 03/01/2017 08:19 PM, Olivier Matz wrote: Introduce a new API to get the status of a descriptor. For Rx, it is almost

Re: [dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-02 Thread Olivier Matz
Hi Andrew, Thank you for the review. Comments inline. On Wed, 1 Mar 2017 21:22:14 +0300, Andrew Rybchenko wrote: > On 03/01/2017 08:19 PM, Olivier Matz wrote: > > Introduce a new API to get the status of a descriptor. > > > > For Rx, it is almost similar to rx_descriptor_done API, except it > >

Re: [dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-01 Thread Andrew Rybchenko
On 03/01/2017 08:19 PM, Olivier Matz wrote: Introduce a new API to get the status of a descriptor. For Rx, it is almost similar to rx_descriptor_done API, except it differentiates "used" descriptors (which are hold by the driver and not returned to the hardware). For Tx, it is a new API. The d

[dpdk-dev] [PATCH 1/6] ethdev: add descriptor status API

2017-03-01 Thread Olivier Matz
Introduce a new API to get the status of a descriptor. For Rx, it is almost similar to rx_descriptor_done API, except it differentiates "used" descriptors (which are hold by the driver and not returned to the hardware). For Tx, it is a new API. The descriptor_done() API, and probably the rx_queu